Re: [Buildroot] [PATCH 1/1] package/tcl: add mandatory dependency to zlib

[Peter Korsgaard <peter@korsgaard.com>]

>>>>> "Julien" == Julien Olivain <ju.o@free.fr> writes:

 > Tcl changed its zlib handling in upstream commit [1]. Before this
 > commit, the HAVE_ZLIB macro was defined only if a zlib headers/library
 > was found. After that commit, the HAVE_ZLIB macro is unconditionally
 > defined. The only change is that: if a working zlib library is found
 > in the toolchain sysroot, it is used. Otherwise, the package will use
 > a shipped version in [2]. See also [3] and [4].

 > This tcl commit is included in Buildroot since commit 7fda943b43
 > "tcl: bump to version 8.6.1".

 > This behavior leads to runtime failures, when the package is compiled
 > with toolchains including zlib in their sysroot. This is because at
 > configuration time, the package will detect zlib in the sysroot and
 > link against it, but the library files won't be installed on target.

 > This happen to be the case with Bootlin toolchains such as [5]. This
 > toolchain also happen to be the one used in basic configurations
 > of the runtime test infrastructure (this issue was found while
 > attempting to write a runtime test for tcl).

 > In such cases, running "tclsh" command fails with error message:

 >     tclsh: error while loading shared libraries: libz.so.1: cannot open shared object file: No such file or directory

 > libtcl library also miss its dependency.

 >     ldd /usr/lib/libtcl8.6.so
 > 	    libz.so.1 => not found
 > 	    libm.so.6 => /lib/libm.so.6 (0xb6dad000)
 > 	    libc.so.6 => /lib/libc.so.6 (0xb6c65000)
 > 	    /lib/ld-linux.so.3 (0xb6f6c000)

 > This commit fixes this issue by adding zlib as a mandatory dependency.

 > [1] https://github.com/tcltk/tcl/commit/6f3dea45cee94f12ffa0b2acbbdb3eedbc01807b
 > [2] https://github.com/tcltk/tcl/tree/core-8-6-13/compat/zlib
 > [3] https://github.com/tcltk/tcl/blob/core-8-6-13/unix/configure.in#L172
 > [4] https://github.com/tcltk/tcl/blob/core-8-6-13/unix/Makefile.in#L240
 > [5] https://toolchains.bootlin.com/downloads/releases/toolchains/armv5-eabi/tarballs/armv5-eabi--glibc--stable-2023.08-1.tar.bz2

 > Signed-off-by: Julien Olivain <ju.o@free.fr>

Committed to 2023.02.x, 2023.05.x and 2023.08.x, thanks.

-- 
Bye, Peter Korsgaard
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot