Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Baruch Siach via buildroot <buildroot@buildroot.org>
To: Fabrice Fontaine <fontaine.fabrice@gmail.com>
Cc: Romain Naour <romain.naour@gmail.com>,
	Giulio Benetti <giulio.benetti@benettiengineering.com>,
	buildroot@buildroot.org
Subject: Re: [Buildroot] [PATCH 1/1] package/binutils: fix install of libstrace
Date: Tue, 19 Sep 2023 07:10:13 +0300	[thread overview]
Message-ID: <871qeun6oi.fsf@tarshish> (raw)
In-Reply-To: <20230918205255.2850663-1-fontaine.fabrice@gmail.com>

Hi Fabrice,

On Mon, Sep 18 2023, Fabrice Fontaine wrote:
> Fix the following build failure with oprofile raised since bump of
> binutils to version 2.40 in commit
> 35656482d3b74ab12a6c2395ac9ca61b60a2fd49:
>
> configure: error: bfd library not found
>
> [...]
>
> configure:17928: checking for bfd_openr in -lbfd
> configure:17953: /home/buildroot/autobuild/run/instance-1/output-1/host/bin/arm-linux-gcc -o conftest -D_LARGEFILE_SOURCE -D_LARGEFILE64_SOURCE -D_FILE_OFFSET_BITS=64  -Os -g0  -D_LARGEFILE_SOURCE -D_LARGEFILE64_SOURCE -D_FILE_OFFSET_BITS=64  conftest.c -lbfd  -liberty -lpopt  -ldl -lintl >&5
> /home/buildroot/autobuild/run/instance-1/output-1/host/opt/ext-toolchain/bin/../lib/gcc/arm-buildroot-linux-uclibcgnueabi/12.3.0/../../../../arm-buildroot-linux-uclibcgnueabi/bin/ld: warning: libsframe.so.0, needed by /home/buildroot/autobuild/run/instance-1/output-1/host/arm-buildroot-linux-uclibcgnueabi/sysroot/usr/lib/libbfd.so, not found (try using -rpath or -rpath-link)
>
> Indeed, in this case, libsframe is not installed even after applying
> commit 1b4d921e1da614a72fed2a79d5c4f8e0b6d1cd45 because
> BR2_BINUTILS_VERSION_2_40_X is not selected by anyone (binutils package
> is selected by oprofile and the toolchain is not generated by buildroot)
>
> To fix this issue, invert the logic: install libsframe by default (i.e.
> when binutils is selected or with a buildroot toolchain). libsframe will
> not be installed only if binutils < 2.40 is detected.

Typo in subject: s/libstrace/libsframe/.

baruch

>
> Fixes:
>  - http://autobuild.buildroot.org/results/af9a2d52823a332b48e6df14d2708b6a4b3833a4
>
> Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
> ---
>  package/binutils/Config.in.host | 6 +++---
>  package/binutils/binutils.mk    | 2 +-
>  2 files changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/package/binutils/Config.in.host b/package/binutils/Config.in.host
> index 36436c0b27..bc7dc4443c 100644
> --- a/package/binutils/Config.in.host
> +++ b/package/binutils/Config.in.host
> @@ -5,7 +5,7 @@ config BR2_PACKAGE_HOST_BINUTILS_SUPPORTS_CFI
>  	default y
>  	depends on !BR2_microblaze
>  
> -config BR2_PACKAGE_BINUTILS_HAS_LIBSFRAME
> +config BR2_PACKAGE_BINUTILS_HAS_NO_LIBSFRAME
>  	bool
>  
>  choice
> @@ -17,18 +17,18 @@ choice
>  
>  config BR2_BINUTILS_VERSION_2_39_X
>  	bool "binutils 2.39"
> +	select BR2_PACKAGE_BINUTILS_HAS_NO_LIBSFRAME
>  
>  config BR2_BINUTILS_VERSION_2_40_X
>  	bool "binutils 2.40"
> -	select BR2_PACKAGE_BINUTILS_HAS_LIBSFRAME
>  
>  config BR2_BINUTILS_VERSION_2_41_X
>  	bool "binutils 2.41"
> -	select BR2_PACKAGE_BINUTILS_HAS_LIBSFRAME
>  
>  config BR2_BINUTILS_VERSION_ARC
>  	bool "binutils arc (2.34.50)"
>  	depends on BR2_arc
> +	select BR2_PACKAGE_BINUTILS_HAS_NO_LIBSFRAME
>  
>  endchoice
>  
> diff --git a/package/binutils/binutils.mk b/package/binutils/binutils.mk
> index ecb00077d6..4bc1b69fa0 100644
> --- a/package/binutils/binutils.mk
> +++ b/package/binutils/binutils.mk
> @@ -105,7 +105,7 @@ endif
>  # our TARGET_CONFIGURE_ARGS are taken into consideration for those
>  BINUTILS_MAKE_ENV = $(TARGET_CONFIGURE_ARGS)
>  
> -ifeq ($(BR2_PACKAGE_BINUTILS_HAS_LIBSFRAME),y)
> +ifeq ($(BR2_PACKAGE_BINUTILS_HAS_NO_LIBSFRAME),)
>  define BINUTILS_INSTALL_STAGING_LIBSFRAME
>  	$(TARGET_MAKE_ENV) $(MAKE) -C $(@D)/libsframe DESTDIR=$(STAGING_DIR) install
>  endef


-- 
                                                     ~. .~   Tk Open Systems
=}------------------------------------------------ooO--U--Ooo------------{=
   - baruch@tkos.co.il - tel: +972.52.368.4656, http://www.tkos.co.il -
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

      reply	other threads:[~2023-09-19  4:11 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-09-18 20:52 [Buildroot] [PATCH 1/1] package/binutils: fix install of libstrace Fabrice Fontaine
2023-09-19  4:10 ` Baruch Siach via buildroot [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=871qeun6oi.fsf@tarshish \
    --to=buildroot@buildroot.org \
    --cc=baruch@tkos.co.il \
    --cc=fontaine.fabrice@gmail.com \
    --cc=giulio.benetti@benettiengineering.com \
    --cc=romain.naour@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox