Re: [Buildroot] How to select python-cryptograhy package

From: Baruch Siach via buildroot <buildroot@buildroot.org>
To: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
Cc: James Hilliard <james.hilliard1@gmail.com>,
	Oscar Gomez Fuente <oscargomezf@gmail.com>,
	Baruch Siach via buildroot <buildroot@buildroot.org>
Subject: Re: [Buildroot] How to select python-cryptograhy package
Date: Fri, 03 Jun 2022 16:47:21 +0300	[thread overview]
Message-ID: <871qw5eu1l.fsf@tarshish> (raw)
In-Reply-To: <20220602190001.0c4c9f35@windsurf>

Hi Thomas,

On Thu, Jun 02 2022, Thomas Petazzoni wrote:
> On Wed, 25 May 2022 10:01:06 +0300
> Baruch Siach via buildroot <buildroot@buildroot.org> wrote:
>
>> The '*' in the table indicates no_std, that is, bare metal. That's most
>> likely not what we want for Buildroot. Can we map BR2_ARM_CPU_ARMV8A to
>> armv7 line the following:
>> 
>> diff --git a/package/rustc/Config.in.host b/package/rustc/Config.in.host
>> index a86d95236d90..6aac703b2a4f 100644
>> --- a/package/rustc/Config.in.host
>> +++ b/package/rustc/Config.in.host
>> @@ -42,6 +42,8 @@ config BR2_PACKAGE_HOST_RUSTC_TARGET_TIER2_HOST_TOOLS_PLATFORMS
>>  	default y if BR2_ARM_CPU_ARMV6 && BR2_ARM_EABIHF && BR2_TOOLCHAIN_USES_GLIBC
>>  	# armv7-unknown-linux-gnueabihf
>>  	default y if BR2_ARM_CPU_ARMV7A && BR2_ARM_EABIHF && BR2_TOOLCHAIN_USES_GLIBC
>> +	# armv8-unknown-linux-gnueabihf
>
> I think this comment would be misleading. Indeed, based on this
> comment, you could think that for this configuration (BR2_arm &&
> BR2_ARM_CPU_ARMV8A && BR2_ARM_EABIHF && BR2_TOOLCHAIN_USES_GLIBC) we
> would use the armv8-unknown-linux-gnueabihf variant of rustc, but
> that's not the one we would be using.

So what should be put in that comment? Just
'armv7-unknown-linux-gnueabihf' like we do for BR2_ARM_CPU_ARMV7A?

baruch

>
>> +	default y if BR2_arm && BR2_ARM_CPU_ARMV8A && BR2_ARM_EABIHF && BR2_TOOLCHAIN_USES_GLIBC
>>  	# mips-unknown-linux-gnu
>>  	default y if BR2_mips && BR2_TOOLCHAIN_USES_GLIBC && !BR2_MIPS_CPU_MIPS32R6
>>  	# mips64-unknown-linux-gnuabi64
>> @@ -86,6 +88,8 @@ config BR2_PACKAGE_HOST_RUSTC_TARGET_TIER2_PLATFORMS
>>  	default y if BR2_ARM_CPU_ARMV7A && BR2_ARM_EABI && BR2_TOOLCHAIN_USES_MUSL
>>  	# armv7-unknown-linux-musleabihf
>>  	default y if BR2_ARM_CPU_ARMV7A && BR2_ARM_EABIHF && BR2_TOOLCHAIN_USES_MUSL
>> +	# armv8-unknown-linux-musleabihf
>> +	default y if BR2_arm && BR2_ARM_CPU_ARMV8A && BR2_ARM_EABIHF && BR2_TOOLCHAIN_USES_MUSL
>
> Same comment of course here.
>
> Other than that, it looks good to me.
>
> Thomas

-- 
                                                     ~. .~   Tk Open Systems
=}------------------------------------------------ooO--U--Ooo------------{=
   - baruch@tkos.co.il - tel: +972.52.368.4656, http://www.tkos.co.il -
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot