From: Peter Korsgaard <peter@korsgaard.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 1/1] package/cups: bump to version 2.2.11 and add gzip fix
Date: Fri, 21 Jun 2019 11:46:03 +0200 [thread overview]
Message-ID: <871rznfezo.fsf@dell.be.48ers.dk> (raw)
In-Reply-To: <20190620182345.61c30d6a@windsurf> (Thomas Petazzoni's message of "Thu, 20 Jun 2019 18:23:45 +0200")
>>>>> "Thomas" == Thomas Petazzoni <thomas.petazzoni@bootlin.com> writes:
Hi,
> This patch is not properly formatted: it is not formatted with "git
> format-patch". In addition, putting a comment before the patch (even if
> it's formatted with git format-patch) makes it impossible to apply the
> patch with "git am".
> The canonical way of generating such patch is:
> git cherry-pick -x 3676fc318a458f71df76620a7e66f5c5807cf9b1
> add your Signed-off-by in the commit log + any comment
NIT: git cherry-pick also understands the -s option to add
signed-off-by, so you can use:
git cherry-pick -sx <commit>
And then just git commit --amend to add any needed comments to the
commit message.
--
Bye, Peter Korsgaard
prev parent reply other threads:[~2019-06-21 9:46 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-18 5:38 [Buildroot] [PATCH 1/1] package/cups: bump to version 2.2.11 and add gzip fix Sam Bobroff
2019-06-20 16:23 ` Thomas Petazzoni
2019-06-21 9:46 ` Peter Korsgaard [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=871rznfezo.fsf@dell.be.48ers.dk \
--to=peter@korsgaard.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox