From: Peter Korsgaard <peter@korsgaard.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH] core/pkg-infra: tweak only .la files that need it
Date: Wed, 27 Mar 2019 15:28:04 +0100 [thread overview]
Message-ID: <871s2stmrv.fsf@dell.be.48ers.dk> (raw)
In-Reply-To: <20190210213818.5232-1-yann.morin.1998@free.fr> (Yann E. MORIN's message of "Sun, 10 Feb 2019 22:38:18 +0100")
>>>>> "Yann" == Yann E MORIN <yann.morin.1998@free.fr> writes:
> Currently, when we tweak the .la files, we do so unconditionally on all
> .la files, even those we already fixed in a previous run.
> This has the nasty side effect that each .la file will be reported as
> being touched by all packages that are installed after the package that
> actually installed said .la file.
> Since we can't easily know what files were installed by a package (that
> is an instrumentation hook, and comes after the mangling), we use a
> trick (like is done in libtool?): we do mangle all files, each into a
> temporary location; if the result is identical to the input, we remove
> the temporary, while if the result differs from the output, we move
> the temporary to replace the input.
> Reported-by: Nicolas Cavallari <nicolas.cavallari@green-communications.fr>
> Reported-by: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
> Signed-off-by: "Yann E. MORIN" <yann.morin.1998@free.fr>
> Cc: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
> Cc: Nicolas Cavallari <nicolas.cavallari@green-communications.fr>
> Cc: Thomas De Schampheleire <patrickdepinguin@gmail.com>
> Cc: Arnout Vandecappelle <arnout@mind.be>
> ---
> Changes v1 -> v2:
> - drop spurious trailing semicolon on sed command line (Thomas DS.)
> - use $$(find ...) instead of $(find ...), as we don't want it to be
> evaluated by the Makefile, but by the shell
> - silence the output of cmp
> - typoes in commit log (Thomas DS.)
Committed to 2019.02.x, thanks.
--
Bye, Peter Korsgaard
next prev parent reply other threads:[~2019-03-27 14:28 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-10 21:38 [Buildroot] [PATCH] core/pkg-infra: tweak only .la files that need it Yann E. MORIN
2019-03-17 15:47 ` Thomas Petazzoni
2019-03-27 14:28 ` Peter Korsgaard [this message]
-- strict thread matches above, loose matches on Subject: below --
2019-02-10 8:48 Yann E. MORIN
2019-02-10 19:23 ` Thomas De Schampheleire
2019-02-10 19:57 ` Yann E. MORIN
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=871s2stmrv.fsf@dell.be.48ers.dk \
--to=peter@korsgaard.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox