Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Peter Korsgaard <peter@korsgaard.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 1/1] gstreamer1: use a relative symlink to gstconfig.h
Date: Thu, 28 Jan 2016 17:55:09 +0100	[thread overview]
Message-ID: <871t91prte.fsf@dell.be.48ers.dk> (raw)
In-Reply-To: <1453987198-26052-1-git-send-email-phil@zankapfel.net> (Phil Eichinger's message of "Thu, 28 Jan 2016 14:19:58 +0100")

>>>>> "Phil" == Phil Eichinger <phil.eichinger@gmail.com> writes:

 > Signed-off-by: Phil Eichinger <phil@zankapfel.net>

Why? Does that fix anything or is it just "prettier"? I get it that we
would need it for a relocatable host dir, but we're not there yet.

A bit more detailed commit message would be good.

> ---
 >  package/gstreamer1/gstreamer1/gstreamer1.mk | 2 +-
 >  1 file changed, 1 insertion(+), 1 deletion(-)

 > diff --git a/package/gstreamer1/gstreamer1/gstreamer1.mk b/package/gstreamer1/gstreamer1/gstreamer1.mk
 > index 4548773..0eb46e8 100644
 > --- a/package/gstreamer1/gstreamer1/gstreamer1.mk
 > +++ b/package/gstreamer1/gstreamer1/gstreamer1.mk
 > @@ -41,7 +41,7 @@ GSTREAMER1_DEPENDENCIES = libglib2 host-pkgconf host-bison host-flex
 >  # updated to look in the correct location.
 >  # Add a symlink to the legacy location
 >  define GSTREAMER1_LEGACY_CGSTCONFIG_H
 > -	ln -sf $(STAGING_DIR)/usr/lib/gstreamer-1.0/include/gst/gstconfig.h \
 > +	ln -srf $(STAGING_DIR)/usr/lib/gstreamer-1.0/include/gst/gstconfig.h \
 >  	       $(STAGING_DIR)/usr/include/gstreamer-1.0/gst/gstconfig.h
 >  endef
 >  GSTREAMER1_POST_INSTALL_STAGING_HOOKS += GSTREAMER1_LEGACY_CGSTCONFIG_H
 > -- 
 > 2.1.4

 > _______________________________________________
 > buildroot mailing list
 > buildroot at busybox.net
 > http://lists.busybox.net/mailman/listinfo/buildroot


-- 
Bye, Peter Korsgaard

  reply	other threads:[~2016-01-28 16:55 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-01-28 13:19 [Buildroot] [PATCH 1/1] gstreamer1: use a relative symlink to gstconfig.h Phil Eichinger
2016-01-28 16:55 ` Peter Korsgaard [this message]
2016-01-29 13:10   ` Phil Eichinger
2016-01-29 13:33     ` Samuel Martin
2016-01-29 14:16       ` Thomas Petazzoni
2016-01-31 19:50 ` Peter Korsgaard

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=871t91prte.fsf@dell.be.48ers.dk \
    --to=peter@korsgaard.com \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox