Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Peter Korsgaard <jacmet@uclibc.org>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 1/1] httping: new package
Date: Tue, 15 Jan 2013 09:23:14 +0100	[thread overview]
Message-ID: <871udmonwt.fsf@dell.be.48ers.dk> (raw)
In-Reply-To: <1358206327-28381-1-git-send-email-gilles.talis@gmail.com> (gilles talis's message of "Mon, 14 Jan 2013 15:32:07 -0800")

>>>>> "gilles" == gilles talis <gilles.talis@gmail.com> writes:

 gilles> From: Gilles Talis <gilles.talis@gmail.com>
 gilles> Httping is like 'ping' but for http-requests.
 gilles> Give it an url, and it'll show you how long it takes to connect,
 gilles> send a request and retrieve the reply (only the headers)

Thanks, committed with minor changes (see below).

 gilles> +++ b/package/httping/Config.in
 gilles> @@ -0,0 +1,23 @@
 gilles> +config BR2_PACKAGE_HTTPING
 gilles> +       bool "httping"
 gilles> +       help
 gilles> +         Httping is like 'ping' but for http-requests.
 gilles> +         Give it an url, and it'll show you how long it takes to connect,
 gilles> +         send a request and retrieve the reply (only the headers).
 gilles> +         Be aware that the transmission across the network also takes time!
 gilles> +         So it measures the latency of the webserver + network.
 gilles> +
 gilles> +         http://www.vanheusden.com/httping/
 gilles> +
 gilles> +if BR2_PACKAGE_HTTPING
 gilles> +
 gilles> +config BR2_PACKAGE_HTTPING_OPENSSL
 gilles> +       bool "OpenSSL support"
 gilles> +       select BR2_PACKAGE_OPENSSL
 gilles> +       help
 gilles> +         Adds openSSL support to httping

We normally automatically add openssl support if the openssl package is
enabled, so I've dropped this option.

 gilles> +
 gilles> +config BR2_PACKAGE_HTTPING_TFO
 gilles> +       bool "TCP Fast Open (TFO) support"

The TFO option seems to add very little overhead, so I think we could
have just always enabled it, but OK.

 gilles> +++ b/package/httping/httping.mk
 gilles> @@ -0,0 +1,37 @@
 gilles> +#############################################################
 gilles> +#
 gilles> +# httping
 gilles> +#
 gilles> +#############################################################
 gilles> +HTTPING_VERSION = 1.5.7

We normally have an empty line before _VERSION.

 gilles> +HTTPING_SOURCE = httping-$(HTTPING_VERSION).tgz
 gilles> +HTTPING_SITE = http://www.vanheusden.com/httping
 gilles> +HTTPING_LICENSE = GPLv2
 gilles> +HTTPING_LICENSE_FILES = license.txt
 gilles> +
 gilles> +ifeq ($(BR2_PACKAGE_HTTPING_OPENSSL),y)
 gilles> +       HTTPING_DEPENDENCIES = openssl
 gilles> +else
 gilles> +       HTTPING_SSL = no
 gilles> +endif

 gilles> +
 gilles> +ifeq ($(BR2_PACKAGE_HTTPING_TFO),y)
 gilles> +       HTTPING_TFO = yes
 gilles> +endif
 gilles> +
 gilles> +define HTTPING_BUILD_CMDS
 gilles> +       $(MAKE) $(TARGET_CONFIGURE_OPTS) \
 gilles> +               SSL=$(HTTPING_SSL) \
 gilles> +               DEBUG=no \
 gilles> +               TFO=$(HTTPING_TFO) -C $(@D)
 gilles> +endef

We normally indent the lines inside defines with <tabs> to be consistent
with make rules. I've cleaned this up a bit while changing the openssl
handling.

 gilles> +
 gilles> +define HTTPING_INSTALL_TARGET_CMDS
 gilles> +       $(INSTALL) -D -m 0755 $(@D)/httping $(TARGET_DIR)/usr/bin/httping

Upstream has a working 'make install', so I changed it to use that
instead.

-- 
Bye, Peter Korsgaard

  reply	other threads:[~2013-01-15  8:23 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-01-14 23:32 [Buildroot] [PATCH 1/1] httping: new package gilles.talis at gmail.com
2013-01-15  8:23 ` Peter Korsgaard [this message]
  -- strict thread matches above, loose matches on Subject: below --
2013-01-13  0:29 Gilles Talis
2013-01-13 11:05 ` Thomas Petazzoni
2013-01-13 20:21   ` Gilles Talis
2013-01-13 20:32     ` Thomas Petazzoni
     [not found]   ` <CAKcgs2xk-=iG-3Ezmc1upEPBjhSGcmgg9WSwn=1E3+OKDT05fg@mail.gmail.com>
2013-01-14  0:47     ` Gilles Talis
2013-01-14 13:02       ` Peter Korsgaard
2013-01-19 13:51         ` Arnout Vandecappelle
2013-01-12  0:00 gilles.talis at gmail.com
2013-01-12 11:07 ` Thomas Petazzoni
2013-01-12 16:37   ` Gilles Talis
2013-01-13  0:37   ` Gilles Talis
2013-01-19 13:39   ` Arnout Vandecappelle

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=871udmonwt.fsf@dell.be.48ers.dk \
    --to=jacmet@uclibc.org \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox