From mboxrd@z Thu Jan 1 00:00:00 1970 From: Peter Korsgaard Date: Thu, 17 May 2012 23:46:50 +0200 Subject: [Buildroot] [PATCH 1/2] socat: fix build failure due to ext2_fs.h header, bump version In-Reply-To: <1337253358-5050-1-git-send-email-thomas.petazzoni@free-electrons.com> (Thomas Petazzoni's message of "Thu, 17 May 2012 13:15:57 +0200") References: <1337253358-5050-1-git-send-email-thomas.petazzoni@free-electrons.com> Message-ID: <871umipjjp.fsf@macbook.be.48ers.dk> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: buildroot@busybox.net >>>>> "Thomas" == Thomas Petazzoni writes: Thomas> In kernel >= 3.3, the ext2_fs.h can no longer be imported from Thomas> userspace. This has been fixed for internal toolchains by adding a Thomas> patch to kernel headers, but this doesn't work with toolchains Thomas> generated by Crosstool-NG, or potentially upcoming external Thomas> toolchains. Thomas> socat in fact has a test in its configure.in, but the configure was Thomas> generated too long ago, and the generated test relies on the Thomas> preprocessor result and not the compiler result (but warns that in the Thomas> future, the compiler result will be used instead of the preprocessor Thomas> result). Thomas> So, by running autoconf on this package, we fix the problem: it Thomas> properly checks whether ext2_fs is usable or not, and acts Thomas> accordingly. Of course, it means that with recent versions of the Thomas> kernel, ext2-specific features of socat are unavailable, and we'll Thomas> have to wait for the socat developers to adapt their code so that they Thomas> use the e2fsprogs headers. Thomas> We also bump the version, since a new minor version fixing a security Thomas> problem has been released. Committed both, thanks. -- Bye, Peter Korsgaard