From: Peter Korsgaard <jacmet@uclibc.org>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCHv2] ext-toolchain: Automatically set -m64 if the architecture is x86_64
Date: Thu, 15 Mar 2012 00:01:46 +0100 [thread overview]
Message-ID: <871uoukcrp.fsf@macbook.be.48ers.dk> (raw)
In-Reply-To: <1331677800-3777-1-git-send-email-arnout@mind.be> (Arnout Vandecappelle's message of "Tue, 13 Mar 2012 23:30:00 +0100")
>>>>> "Arnout" == Arnout Vandecappelle (Essensium/Mind) <arnout@mind.be> writes:
Arnout> Without the -m64, choosing the x86_64 architecture with a Sourcery external
Arnout> toolchain will result in a 32-bit rootfs.
Arnout> Also simplified the help text to reflect this change.
Arnout> Signed-off-by: Arnout Vandecappelle (Essensium/Mind) <arnout@mind.be>
Arnout> ---
Arnout> v2: Feedback from Thomas
Arnout> * Less aggressive modification of the help text.
Arnout> * Make -m64 flag specific for x86_64.
Arnout> Build-tested only.
Arnout> toolchain/toolchain-external/Config.in | 35 +++++++++++---------
Arnout> toolchain/toolchain-external/ext-tool.mk | 4 ++
Arnout> .../toolchain-external/ext-toolchain-wrapper.c | 3 ++
Arnout> 3 files changed, 26 insertions(+), 16 deletions(-)
Arnout> diff --git a/toolchain/toolchain-external/Config.in b/toolchain/toolchain-external/Config.in
Arnout> index 7f57952..8c20661 100644
Arnout> --- a/toolchain/toolchain-external/Config.in
Arnout> +++ b/toolchain/toolchain-external/Config.in
Arnout> @@ -371,14 +371,16 @@ config BR2_TOOLCHAIN_EXTERNAL_CODESOURCERY_X86_201109
Arnout> binutils 2.21.53, glibc 2.13, gdb 7.2.50 and kernel headers
Arnout> 3.0.1. It has support for the following variants:
Arnout> - Intel Pentium 4, glibc, 32 bits
Arnout> - Default, nothing special to do.
Arnout> - - Intel Atom, glibc, 32 bits
Arnout> - Select an Atom core
Arnout> - - Intel Xeon, glibc, 64 bits
Arnout> - Set BR2_TARGET_OPTIMIZATION to -m64
Arnout> - - Intel Core 2, glibc, 64 bits
Arnout> - Select a Core 2 core
Arnout> - Set BR2_TARGET_OPTIMIZATION to -m64
Arnout> + Default for x86, nothing special to do.
Arnout> + - Intel Atom, glibc, 32 bits
Arnout> + Select an Atom core
Arnout> + - Intel Xeon, glibc, 64 bits
Arnout> + Default for x86_64, nothing special to do.
Arnout> + - Intel Core 2, glibc, 64 bits
Arnout> + Select a Core 2 core
Arnout> + Other architecture variants (beyond Pentium-4/Xeon) are
Arnout> + supported as well, but glibc is not optimised for it.
Arnout> +
You have some whitespace damage here, but otherwise it looks good -
Committed, thanks.
--
Bye, Peter Korsgaard
next prev parent reply other threads:[~2012-03-14 23:01 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-01-21 18:04 [Buildroot] [PATCH] ext-toolchain: Automatically set -m64 if the architecture is x86_64 Arnout Vandecappelle
2012-01-23 21:36 ` Thomas Petazzoni
2012-03-05 10:12 ` Thomas Petazzoni
2012-03-13 21:55 ` Arnout Vandecappelle
2012-03-14 22:23 ` Thomas Petazzoni
2012-03-13 22:30 ` [Buildroot] [PATCHv2] " Arnout Vandecappelle
2012-03-14 22:25 ` Thomas Petazzoni
2012-03-14 23:01 ` Peter Korsgaard [this message]
2012-03-15 8:17 ` Arnout Vandecappelle
2012-03-15 9:44 ` Peter Korsgaard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=871uoukcrp.fsf@macbook.be.48ers.dk \
--to=jacmet@uclibc.org \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox