Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Peter Korsgaard <jacmet@uclibc.org>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 1/2] toolchain: add option to enable AI_ADDRCONFIG support in uclibc
Date: Sun, 11 Mar 2012 21:53:43 +0100	[thread overview]
Message-ID: <871uoy3lm0.fsf@macbook.be.48ers.dk> (raw)
In-Reply-To: <1331159898-25350-2-git-send-email-s.neumann@raumfeld.com> (Sven Neumann's message of "Wed, 7 Mar 2012 23:38:17 +0100")

>>>>> "Sven" == Sven Neumann <s.neumann@raumfeld.com> writes:

 Sven> Some packages need ifaddr.h which is only included in uclibc if
 Sven> UCLIBC_SUPPORT_AI_ADDRCONFIG is selected. Make this configurable
 Sven> as a buildroot option so that those packages can select it.

 Sven> +ifeq ($(BR2_TOOLCHAIN_BUILDROOT_INET_ADDRCONFIG),y)
 Sven> +	$(SED) 's,^.*UCLIBC_SUPPORT_AI_ADDRCONFIG.*,UCLIBC_SUPPORT_AI_ADDRCONFIG=y,g' $(UCLIBC_DIR)/.oldconfig
 Sven> +else
 Sven> +	$(SED) 's,.*UCLIBC_SUPPORT_AI_ADDRCONFIG.*,UCLIBC_SUPPORT_AI_ADDRCONFIG=n,g' $(UCLIBC_DIR)/.oldconfig
 Sven> +	$(SED) '/.*UCLIBC_SUPPORT_AI_ADDRCONFIG.*/d' $(UCLIBC_DIR)/.oldconfig
 Sven> +	echo "# UCLIBC_SUPPORT_AI_ADDRCONFIG is not set" >> $(UCLIBC_DIR)/.oldconfig

Why the complication and not just something like:

 $(SED) 's,^.*UCLIBC_SUPPORT_AI_ADDRCONFIG.*,#  UCLIBC_SUPPORT_AI_ADDRCONFIG is not set,g' $(UCLIBC_DIR)/.oldconfig

We'll also need to add the option for external toolchains, but I can do
that, thanks for doing the patch.

-- 
Bye, Peter Korsgaard

  reply	other threads:[~2012-03-11 20:53 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-03-07 22:38 [Buildroot] add option to enable AI_ADDRCONFIG support Sven Neumann
2012-03-07 22:38 ` [Buildroot] [PATCH 1/2] toolchain: add option to enable AI_ADDRCONFIG support in uclibc Sven Neumann
2012-03-11 20:53   ` Peter Korsgaard [this message]
2012-03-07 22:38 ` [Buildroot] [PATCH 2/2] mrouted: select BR2_TOOLCHAIN_BUILDROOT_INET_ADDRCONFIG Sven Neumann
2012-03-08  8:17 ` [Buildroot] add option to enable AI_ADDRCONFIG support Thomas Petazzoni
2012-03-11 20:56   ` Peter Korsgaard
2012-03-15 20:33     ` Thomas Petazzoni
2012-03-15 20:56       ` Peter Korsgaard
2012-05-02 13:33         ` Gustavo Zacarias

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=871uoy3lm0.fsf@macbook.be.48ers.dk \
    --to=jacmet@uclibc.org \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox