Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Peter Korsgaard <jacmet@uclibc.org>
To: buildroot@busybox.net
Subject: [Buildroot] svn commit: trunk/buildroot/package/qte
Date: Fri, 30 Jan 2009 11:56:26 +0100	[thread overview]
Message-ID: <871vulnjtx.fsf@macbook.be.48ers.dk> (raw)
In-Reply-To: <20090130105001.98CDB765E9@busybox.osuosl.org> (laird@uclibc.org's message of "Fri\, 30 Jan 2009 10\:50\:01 +0000 \(UTC\)")

>>>>> "laird" == laird  <laird@uclibc.org> writes:

 laird> Author: laird
 laird> Date: 2009-01-30 10:49:59 +0000 (Fri, 30 Jan 2009)
 laird> New Revision: 25162

 laird> Log:
 laird> qte.mk: Use depends on for toolchain features 

 laird> Buildroot is adopting depends on for toolchain features and
 laird> select for packages. Make this change in this file.
 
 laird> Signed-off-by: Daniel Laird <daniel.j.laird@nxp.com>

 laird> @@ -2,7 +2,7 @@
 laird>  	bool "Qt/E"
 laird>  	depends on BR2_DEPRECATED
 laird>  	depends on BR2_INSTALL_LIBSTDCPP
 laird> -	select BR2_PTHREADS_NATIVE
 laird> +	depends on BR2_PTHREADS_NATIVE
 laird>  	select BR2_PACKAGE_JPEG
 laird>  	select BR2_PACKAGE_LIBPNG
 laird>  	help

You forgot to update comment so people can know how to enable it:

comment "Qt/E requires a toolchain with C++ support enabled"
        depends on !BR2_INSTALL_LIBSTDCPP
        depends on BR2_DEPRECATED

That one should depend on !BR2_PTHREADS_NATIVE and the text should get
updated.

-- 
Bye, Peter Korsgaard

  reply	other threads:[~2009-01-30 10:56 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-01-30 10:50 [Buildroot] svn commit: trunk/buildroot/package/qte laird at uclibc.org
2009-01-30 10:56 ` Peter Korsgaard [this message]
  -- strict thread matches above, loose matches on Subject: below --
2009-01-30 11:30 laird at uclibc.org
2008-08-27 20:19 jacmet at uclibc.org
2008-07-01 13:58 correa at uclibc.org
2007-07-24 14:14 ulf at uclibc.org
2006-11-17 22:58 andersen at uclibc.org

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=871vulnjtx.fsf@macbook.be.48ers.dk \
    --to=jacmet@uclibc.org \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox