Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Jeremy Rosen <jeremy.rosen@openwide.fr>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH] change default location for local.mk to $(CONFIG_DIR)
Date: Thu, 14 Mar 2013 09:37:38 +0100 (CET)	[thread overview]
Message-ID: <872634236.491763.1363250258384.JavaMail.root@openwide.fr> (raw)
In-Reply-To: <513FA25B.5030908@mind.be>

> 
>   But $(CONFIG_DIR) is not a good location then... $(CONFIG_DIR) is
> $(TOPDIR) if doing in-tree build, and $(O) if doing out-of-tree
> build.
> When you delete your out-of-tree dir, local.mk will also be gone...
> 

when you build out-of-tree, you want your config to be in the O= 
directory (that's the whole point of O= as I understand it) so when 
you remove that directory you loose your .config and thus all your 
customisation. It makes sense to have local.mk there too, since 
it's also customisation. But maybe I am missing something and that's 
not the point of O= 

but in that case, what is the recommanded way of not having the .config 
in $(TOPDIR) ? is that not what I am supposed to do ? how can I save my
.config in a git repo if I have to keep it in $(TOPDIR) which is already
a buildroot repo ?

I don't want to commit my .config in the buildroot repo because if I
want to upstream my changes to $(TOPDIR) at any point, the changes to
.config will be mangled in the middle. My philosophy is that $(TOPDIR)
changes should only be potentially upstreamable stuff...


>   I also don't really like the idea that with a defconfig, the build
> result will be different when you change the O= command line
> parameter.
> 

again, I might misunderstand the point of O= but I thought that was the
very idea behind it... have multiple projects sharing their $(TOPDIR), 
maybe their dl/ subdirectory, but not their .config

there is no risk of accidentally using an incorrect O= since O= is only
used for initialisation. After that, there is a makefile in $(CONFIG_DIR)
that properly redirect you 


> 
>   Regards,
>   Arnout
> 
> 
> --
> Arnout Vandecappelle                          arnout at mind be
> Senior Embedded Software Architect            +32-16-286500
> Essensium/Mind                                http://www.mind.be
> G.Geenslaan 9, 3001 Leuven, Belgium           BE 872 984 063 RPR
> Leuven
> LinkedIn profile: http://www.linkedin.com/in/arnoutvandecappelle
> GPG fingerprint:  7CB5 E4CC 6C2E EFD4 6E3D A754 F963 ECAB 2450 2F1F
> 

  reply	other threads:[~2013-03-14  8:37 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-03-07 10:49 [Buildroot] [PATCH] change default location for local.mk to $(CONFIG_DIR) Jérémy Rosen
2013-03-11 21:26 ` Thomas Petazzoni
2013-03-12  8:12   ` Jeremy Rosen
2013-03-12 21:47     ` Arnout Vandecappelle
2013-03-14  8:37       ` Jeremy Rosen [this message]
2013-03-18  6:46         ` Arnout Vandecappelle
2013-03-18  8:10           ` Jeremy Rosen
2013-03-12  8:26   ` Thomas De Schampheleire
2013-03-15 11:46     ` Thomas Petazzoni

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=872634236.491763.1363250258384.JavaMail.root@openwide.fr \
    --to=jeremy.rosen@openwide.fr \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox