Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
* [Buildroot] [PATCH v2] package/swipl: fix build without C++ compiler
@ 2025-02-05 12:00 Peter Korsgaard
  2025-02-05 12:03 ` Thomas Petazzoni
  2025-02-08 17:00 ` Peter Korsgaard
  0 siblings, 2 replies; 3+ messages in thread
From: Peter Korsgaard @ 2025-02-05 12:00 UTC (permalink / raw)
  To: buildroot; +Cc: Julien Olivain

Fixes http://autobuild.buildroot.net/results/b24a96b999676990995a466686fe1eacf6cddfef

Some of the optional packages in swipl are written in C++, so CMake thinks a
C++ compiler is needed even though we build with -DSWIPL_PACKAGES=OFF since
the bump to 9.2.6 in commit 33d45b9c672df0 ("package/swipl: bump version to
9.2.6").

Add -DCMAKE_CXX_COMPILER=true to satisfy this check even in setups without
C++:

-- Check for working CXX compiler: /usr/bin/true
-- Check for working CXX compiler: /usr/bin/true - works

Signed-off-by: Peter Korsgaard <peter@korsgaard.com>
---
Changes since v1:
- Add info about since when the issue occurs.

 package/swipl/swipl.mk | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/package/swipl/swipl.mk b/package/swipl/swipl.mk
index ef9aedcd2d..e29b8d8f46 100644
--- a/package/swipl/swipl.mk
+++ b/package/swipl/swipl.mk
@@ -36,7 +36,8 @@ SWIPL_CONF_OPTS = \
 	-DQSORT_R_GNU=1 \
 	-DSWIPL_NATIVE_FRIEND=$(HOST_SWIPL_SRCDIR) \
 	-DSWIPL_PACKAGES=OFF \
-	-DUSE_TCMALLOC=OFF
+	-DUSE_TCMALLOC=OFF \
+	-DCMAKE_CXX_COMPILER=true
 
 ifeq ($(BR2_TOOLCHAIN_HAS_LIBATOMIC),y)
 SWIPL_CONF_OPTS += -DCMAKE_EXE_LINKER_FLAGS=-latomic
-- 
2.39.5

_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [Buildroot] [PATCH v2] package/swipl: fix build without C++ compiler
  2025-02-05 12:00 [Buildroot] [PATCH v2] package/swipl: fix build without C++ compiler Peter Korsgaard
@ 2025-02-05 12:03 ` Thomas Petazzoni
  2025-02-08 17:00 ` Peter Korsgaard
  1 sibling, 0 replies; 3+ messages in thread
From: Thomas Petazzoni @ 2025-02-05 12:03 UTC (permalink / raw)
  To: Peter Korsgaard; +Cc: buildroot, Julien Olivain

On Wed,  5 Feb 2025 13:00:58 +0100
Peter Korsgaard <peter@korsgaard.com> wrote:

> Fixes http://autobuild.buildroot.net/results/b24a96b999676990995a466686fe1eacf6cddfef
> 
> Some of the optional packages in swipl are written in C++, so CMake thinks a
> C++ compiler is needed even though we build with -DSWIPL_PACKAGES=OFF since
> the bump to 9.2.6 in commit 33d45b9c672df0 ("package/swipl: bump version to
> 9.2.6").
> 
> Add -DCMAKE_CXX_COMPILER=true to satisfy this check even in setups without
> C++:
> 
> -- Check for working CXX compiler: /usr/bin/true
> -- Check for working CXX compiler: /usr/bin/true - works
> 
> Signed-off-by: Peter Korsgaard <peter@korsgaard.com>
> ---
> Changes since v1:
> - Add info about since when the issue occurs.

Applied to master, thanks.

Thomas
-- 
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [Buildroot] [PATCH v2] package/swipl: fix build without C++ compiler
  2025-02-05 12:00 [Buildroot] [PATCH v2] package/swipl: fix build without C++ compiler Peter Korsgaard
  2025-02-05 12:03 ` Thomas Petazzoni
@ 2025-02-08 17:00 ` Peter Korsgaard
  1 sibling, 0 replies; 3+ messages in thread
From: Peter Korsgaard @ 2025-02-08 17:00 UTC (permalink / raw)
  To: buildroot; +Cc: Julien Olivain

>>>>> "Peter" == Peter Korsgaard <peter@korsgaard.com> writes:

 > Fixes http://autobuild.buildroot.net/results/b24a96b999676990995a466686fe1eacf6cddfef
 > Some of the optional packages in swipl are written in C++, so CMake thinks a
 > C++ compiler is needed even though we build with -DSWIPL_PACKAGES=OFF since
 > the bump to 9.2.6 in commit 33d45b9c672df0 ("package/swipl: bump version to
 > 9.2.6").

 > Add -DCMAKE_CXX_COMPILER=true to satisfy this check even in setups without
 > C++:

 > -- Check for working CXX compiler: /usr/bin/true
 > -- Check for working CXX compiler: /usr/bin/true - works

 > Signed-off-by: Peter Korsgaard <peter@korsgaard.com>
 > ---
 > Changes since v1:
 > - Add info about since when the issue occurs.

Committed to 2024.11.x, thanks.

-- 
Bye, Peter Korsgaard
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2025-02-08 17:00 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-02-05 12:00 [Buildroot] [PATCH v2] package/swipl: fix build without C++ compiler Peter Korsgaard
2025-02-05 12:03 ` Thomas Petazzoni
2025-02-08 17:00 ` Peter Korsgaard

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox