Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Peter Korsgaard <peter@korsgaard.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH v2, 2/2] package/domoticz: select boost atomic
Date: Mon, 26 Apr 2021 23:07:34 +0200	[thread overview]
Message-ID: <8735vcg3ft.fsf@dell.be.48ers.dk> (raw)
In-Reply-To: <20210426191113.512637-2-fontaine.fabrice@gmail.com> (Fabrice Fontaine's message of "Mon, 26 Apr 2021 21:11:13 +0200")

>>>>> "Fabrice" == Fabrice Fontaine <fontaine.fabrice@gmail.com> writes:

 > domoticz does not use Boost::atomic but cmake is so "smart" that it
 > (wrongly) assumes that Boost::thread depends on Boost:date_time and
 > Boost::atomic since boost version 1.54:

 > set(_Boost_THREAD_DEPENDENCIES chrono date_time atomic)

 > Extracted from:
 >  - https://gitlab.kitware.com/cmake/cmake/-/blob/master/Modules/FindBoost.cmake#L1113

 > As we can't patch every cmake on the field, just select boost atomic

 > It should be noted that build failures are only raised since commit
 > 8a46b41b4a5d1c2f5ebefd7fc23fec7e8ba0598c as this commit drop the patch
 > that was decreasing cmake version but also removing:

 > target_link_libraries(domoticz Boost::thread Boost::system)

 > Fixes:
 >  - http://autobuild.buildroot.org/results/4306c0a725ed9a34bd55550df428866db6e4f052
 >  - http://autobuild.buildroot.org/results/2478e7a2ec1c63dcc2b36d29a39004468b230211

 > Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
 > ---
 > Changes v1 -> v2:
 >  - Fix patch title

Committed to 2021.02.x, thanks.

-- 
Bye, Peter Korsgaard

  parent reply	other threads:[~2021-04-26 21:07 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-04-26 19:11 [Buildroot] [PATCH v2, 1/2] Revert "package/domoticz: drop boost date-time dependency" Fabrice Fontaine
2021-04-26 19:11 ` [Buildroot] [PATCH v2,2/2] package/domoticz: select boost atomic Fabrice Fontaine
2021-04-26 19:50   ` [Buildroot] [PATCH v2, 2/2] " Yann E. MORIN
2021-04-26 21:07   ` Peter Korsgaard [this message]
2021-04-26 19:49 ` [Buildroot] [PATCH v2, 1/2] Revert "package/domoticz: drop boost date-time dependency" Yann E. MORIN
2021-04-26 21:07 ` Peter Korsgaard

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=8735vcg3ft.fsf@dell.be.48ers.dk \
    --to=peter@korsgaard.com \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox