From mboxrd@z Thu Jan 1 00:00:00 1970 From: Baruch Siach Date: Thu, 25 Mar 2021 16:22:46 +0200 Subject: [Buildroot] [PATCH] package/libbytesize: remove pcre2 runtime dependency In-Reply-To: <226176cabe249af62546689fbb39de8a7010c329.1616681740.git.stefan@agner.ch> References: <226176cabe249af62546689fbb39de8a7010c329.1616681740.git.stefan@agner.ch> Message-ID: <8735wjl3d5.fsf@tarshish> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: buildroot@busybox.net Hi Stefan, On Thu, Mar 25 2021, Stefan Agner wrote: > The library is only required at build time, which is handled by the > select in Config.in. The _DEPENDENCIES list is meant to make sure that pcre2 builds before libbytesize. Config.in select does not guarantee the build order. Config.in select only makes pcre2 build. So if pcre2 is required at build time we need it in the _DEPENDENCIES list. Am I missing something? baruch > Signed-off-by: Stefan Agner > --- > package/libbytesize/libbytesize.mk | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/package/libbytesize/libbytesize.mk b/package/libbytesize/libbytesize.mk > index 0ba380dc74..df54ae84b7 100644 > --- a/package/libbytesize/libbytesize.mk > +++ b/package/libbytesize/libbytesize.mk > @@ -14,8 +14,7 @@ LIBBYTESIZE_DEPENDENCIES = \ > host-pkgconf \ > host-gettext \ > gmp \ > - mpfr \ > - pcre2 > + mpfr > > LIBBYTESIZE_CONF_OPTS += \ > --without-python3 \ -- ~. .~ Tk Open Systems =}------------------------------------------------ooO--U--Ooo------------{= - baruch at tkos.co.il - tel: +972.52.368.4656, http://www.tkos.co.il -