From: Peter Korsgaard <peter@korsgaard.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH] package/gcc/9.x: fix download url when using upstream gcc for csky
Date: Sat, 21 Mar 2020 20:59:46 +0100 [thread overview]
Message-ID: <8736a15vil.fsf@dell.be.48ers.dk> (raw)
In-Reply-To: <20200312234127.449204-1-romain.naour@smile.fr> (Romain Naour's message of "Fri, 13 Mar 2020 00:41:26 +0100")
>>>>> "Romain" == Romain Naour <romain.naour@smile.fr> writes:
> When the csky cpu support was added [1], the gcc download url was selected
> depending on the csky cpu architecture (BR2_csky) rather than the csky gcc
> fork version (BR2_GCC_VERSION_CSKY)[2].
> When adding gcc 9.x version [3], we forgot to update the condition in order
> to use the url to the gcc csky fork only when BR2_GCC_VERSION_CSKY=y.
> Due to this error, the toolchain build with the upstream gcc 9.x for csky
> cpu is broken due a download error.
> Fix this by using BR2_GCC_VERSION_CSKY instead of BR2_csky.
> Fixes:
> https://gitlab.com/kubu93/buildroot/-/jobs/470072924
> [1] 7873a5bd5ebbeb1674293dae6b06b50f0a1f2184
> [2]
> https://git.buildroot.net/buildroot/tree/package/gcc/gcc.mk?id=7873a5bd5ebbeb1674293dae6b06b50f0a1f2184#n19
> [3] 089000eccf584d611ad1a8e5400436952450e883
> Signed-off-by: Romain Naour <romain.naour@smile.fr>
> Cc: Yann E. MORIN <yann.morin.1998@free.fr>
> Cc: Guo Ren <guoren@kernel.org>
> Cc: Arnout Vandecappelle <arnout@mind.be>
> Cc: Peter Korsgaard <peter@korsgaard.com>
Committed to 2019.11.x and 2020.02.x, thanks.
--
Bye, Peter Korsgaard
prev parent reply other threads:[~2020-03-21 19:59 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-12 23:41 [Buildroot] [PATCH] package/gcc/9.x: fix download url when using upstream gcc for csky Romain Naour
2020-03-12 23:41 ` [Buildroot] [PATCH] package/gcc: disable gcc 9.x " Romain Naour
2020-03-14 14:16 ` Thomas Petazzoni
2020-03-21 20:00 ` Peter Korsgaard
2020-03-21 20:00 ` Peter Korsgaard
2020-03-14 14:16 ` [Buildroot] [PATCH] package/gcc/9.x: fix download url when using upstream gcc " Thomas Petazzoni
2020-03-21 19:59 ` Peter Korsgaard [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8736a15vil.fsf@dell.be.48ers.dk \
--to=peter@korsgaard.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox