Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Peter Korsgaard <peter@korsgaard.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH v2 6/7] tpm2-tools: do not enforce dependency on tpm2-abrmd
Date: Fri, 25 Jan 2019 16:03:49 +0100	[thread overview]
Message-ID: <8736pgu6cq.fsf@dell.be.48ers.dk> (raw)
In-Reply-To: <b169a705-b11b-cd83-4b74-f593f1d2e2fc@mind.be> (Arnout Vandecappelle's message of "Thu, 24 Jan 2019 17:50:31 +0100")

>>>>> "Arnout" == Arnout Vandecappelle <arnout@mind.be> writes:

Hi,

 >  For the situations like the one in this patch, I would say that we could relax
 > a little the 'avoid extra per-package configuration options'. In fact, extra
 > configuration options in Config.in don't cost that much. They don't really make
 > the menus larger because they're only visible when the package is selected. And
 > the .mk handling is the same as for an automatic optional dependency. That said,
 > in this specific case of tpm2-tools, I have the feeling that an additional
 > option is not appropriate. Since the two packages are right next to each other,
 > that is almost the same as having the suboption. So I would go for the help text
 > instead.

Ok, I'll send an updated patch that drops the select and adds a note in
the help text instead.

-- 
Bye, Peter Korsgaard

  reply	other threads:[~2019-01-25 15:03 UTC|newest]

Thread overview: 27+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-01-15 10:15 [Buildroot] [PATCH v2 1/7] tpm2-tss: do not enforce -fstack-protector-all Peter Korsgaard
2019-01-15 10:15 ` [Buildroot] [PATCH v2 2/7] tpm2-tss: fix build with BR2_FORTIFY_SOURCE_1 Peter Korsgaard
2019-01-16 13:26   ` Peter Korsgaard
2019-01-25  7:28   ` Peter Korsgaard
2019-01-15 10:15 ` [Buildroot] [PATCH v2 3/7] tpm2-tools: always disable hardening options Peter Korsgaard
2019-01-16 13:25   ` Peter Korsgaard
2019-01-25  7:28   ` Peter Korsgaard
2019-01-15 10:15 ` [Buildroot] [PATCH v2 4/7] tpm2-abrmd: do not enforce -fstack-protector-all Peter Korsgaard
2019-01-16 13:25   ` Peter Korsgaard
2019-01-25  7:29   ` Peter Korsgaard
2019-01-15 10:15 ` [Buildroot] [PATCH v2 5/7] tpm2-abrmd: fix build with BR2_FORTIFY_SOURCE_1 Peter Korsgaard
2019-01-16 13:25   ` Peter Korsgaard
2019-01-25  7:29   ` Peter Korsgaard
2019-01-15 10:15 ` [Buildroot] [PATCH v2 6/7] tpm2-tools: do not enforce dependency on tpm2-abrmd Peter Korsgaard
2019-01-15 20:43   ` Yann E. MORIN
2019-01-16 11:43     ` Peter Korsgaard
2019-01-17 15:58       ` Yann E. MORIN
2019-01-17 19:01         ` Peter Korsgaard
2019-01-28 21:23           ` Yann E. MORIN
2019-01-28 22:08             ` Peter Korsgaard
2019-01-24 16:50         ` Arnout Vandecappelle
2019-01-25 15:03           ` Peter Korsgaard [this message]
2019-01-15 10:15 ` [Buildroot] [PATCH v2 7/7] tpm2-abrmd: S80tpm2-abrmd: create pid file at startup Peter Korsgaard
2019-01-16 13:26   ` Peter Korsgaard
2019-01-25  7:30   ` Peter Korsgaard
2019-01-16 13:25 ` [Buildroot] [PATCH v2 1/7] tpm2-tss: do not enforce -fstack-protector-all Peter Korsgaard
2019-01-25  7:28 ` Peter Korsgaard

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=8736pgu6cq.fsf@dell.be.48ers.dk \
    --to=peter@korsgaard.com \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox