From: Peter Korsgaard <peter@korsgaard.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH] ifupdown-script: send current hostname in DHCP request
Date: Mon, 05 Nov 2018 23:22:03 +0100 [thread overview]
Message-ID: <8736sfcghg.fsf@dell.be.48ers.dk> (raw)
In-Reply-To: <CANQCQpbA-2rdHtpBs8sE=R0UE0R+GGY4fXza-kxtY+x_7LrLdg@mail.gmail.com> (Matthew Weber's message of "Thu, 1 Nov 2018 22:28:17 -0500")
>>>>> "Matthew" == Matthew Weber <matthew.weber@rockwellcollins.com> writes:
> Peter,
> On Tue, Oct 30, 2018 at 12:16 PM Peter Korsgaard <peter@korsgaard.com> wrote:
>>
>> For the default (BR2_SYSTEM_DHCP) /etc/network/interfaces handling.
>>
>> Both the "big" and busybox ifupdown variants pass the hostname argument to
>> the DHCP client through the shell, so we can use $() to expand to the
>> current hostname value.
>>
> The man page for the interfaces file mentioned that only pump, dhcpcd
> and udhcpc use the hostname value from interfaces. With dhclient
> requiring the dhclient.conf to specify the set hostname option with
> the hostname string. Would it be worth mentioning that here in the
> comment that for most (pump, dhcpcd, udhcpc) the hostname parameter
> will work but some clients like dhclient require a separate
> configuration file?
> Reviewed-by: Matt Weber <matthew.weber@rockwellcollins.com>
I've added a comment about that and applied, thanks.
--
Bye, Peter Korsgaard
prev parent reply other threads:[~2018-11-05 22:22 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-30 17:16 [Buildroot] [PATCH] ifupdown-script: send current hostname in DHCP request Peter Korsgaard
2018-11-02 3:28 ` Matthew Weber
2018-11-05 22:22 ` Peter Korsgaard [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8736sfcghg.fsf@dell.be.48ers.dk \
--to=peter@korsgaard.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox