From mboxrd@z Thu Jan 1 00:00:00 1970 From: Baruch Siach Date: Fri, 10 Aug 2018 08:43:25 +0300 Subject: [Buildroot] [PATCH] uboot-tools: requires host gcc 4.7+ In-Reply-To: <20180808150458.v3onrufmufhe67su@sapphire.tkos.co.il> References: <87tvo5exs2.fsf@dell.be.48ers.dk> <20180808143953.nxylmvq2ehhs6mx5@sapphire.tkos.co.il> <87pnysgb79.fsf@dell.be.48ers.dk> <20180808150458.v3onrufmufhe67su@sapphire.tkos.co.il> Message-ID: <8736vmbwua.fsf@tkos.co.il> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: buildroot@busybox.net Hi Peter, Baruch Siach writes: > On Wed, Aug 08, 2018 at 04:55:06PM +0200, Peter Korsgaard wrote: >> >>>>> "Baruch" == Baruch Siach writes: >> >> > config BR2_PACKAGE_UBOOT_TOOLS >> >> > bool "u-boot tools" >> >> > + depends on BR2_HOST_GCC_AT_LEAST_4_7 # -std=gnu11 >> >> >> >> What about host-uboot-tools? >> >> > The only config symbols that builds host-uboot-tools is >> > BR2_PACKAGE_XVISOR_CREATE_UBOOT_IMAGE. So we should make it depend on >> > BR2_HOST_GCC_AT_LEAST_4_7, right? >> >> > AFAIU, there is no way to directly make host packages depend on Kconfig >> > symbols. >> >> Ehh, but we do have a Config.in.host / BR2_PACKAGE_HOST_UBOOT_TOOLS, and >> a number of places where it is selected? > > I see. I'll run another build just to verify that -std=gnu11 is used in > host-uboot-tools, and send another patch. It turns out that host-uboot-tools is not affected. That's because we force host CFLAGS in HOST_UBOOT_TOOLS_MAKE_OPTS. I posted a patch that does the same for uboot-tools, and marked this patch as Rejected. baruch -- http://baruch.siach.name/blog/ ~. .~ Tk Open Systems =}------------------------------------------------ooO--U--Ooo------------{= - baruch at tkos.co.il - tel: +972.52.368.4656, http://www.tkos.co.il -