Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Peter Korsgaard <peter@korsgaard.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH] ncurses: make host-ncurses use host terminfo
Date: Thu, 19 Jul 2018 23:38:59 +0200	[thread overview]
Message-ID: <8736wec3d8.fsf@dell.be.48ers.dk> (raw)
In-Reply-To: <5f7fe697b92ac0145674.1531241163@cveaol6qa08.wv.mentorg.com> (Hollis Blanchard's message of "Tue, 10 Jul 2018 09:46:03 -0700")

>>>>> "Hollis" == Hollis Blanchard <hollis_blanchard@mentor.com> writes:

 > # HG changeset patch
 > # User Hollis Blanchard <hollis_blanchard@mentor.com>
 > # Date 1531239381 25200
 > #      Tue Jul 10 09:16:21 2018 -0700
 > # Node ID 5f7fe697b92ac0145674a6c96aad0f787b4bae32
 > # Parent  d71314cdccf1993ccdb05cddb16a5491f0bf723e
 > ncurses: make host-ncurses use host terminfo

 > Host GDB suffers a serious problem: pressing backspace (or ^W ^U or any other
 > "delete" key) results in a plain space being printed instead, making the
 > command prompt almost completely unusable.

 > That's because it's using host-ncurses, which embeds a path for the terminfo
 > database into the library itself. That path ends up being something like
 > /home/hollisb/buildroot.git/output/host/share/terminfo, which obviously doesn't
 > generally exist other hosts. ('relocate-sdk.sh' cannot and does not edit
 > binaries like libncurses.so.6, so doesn't resolve this problem.)

 > /usr/share/terminfo is a far better path to use, since it almost certainly
 > exists on the host. Theoretically, it could be from a different ncurses version
 > with incompatible terminfo database format, but this doesn't seem to be a
 > problem in practice. (Future patches could address the theoretical problem if
 > it actually appears in real life.)

 > This change allows buildroot's host gdb, which uses ncurses 6.x, to work on
 > RHEL5, RHEL6, and RHEL7, which all provide terminfo from ncurses 5.x.

 > Signed-off-by: Hollis Blanchard <hollis_blanchard@mentor.com>

Committed to 2018.02.x and 2018.05.x, thanks.

-- 
Bye, Peter Korsgaard

  parent reply	other threads:[~2018-07-19 21:38 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-07-10 16:46 [Buildroot] [PATCH] ncurses: make host-ncurses use host terminfo Hollis Blanchard
2018-07-10 19:52 ` Arnout Vandecappelle
2018-07-17 14:40 ` Thomas Petazzoni
2018-07-17 16:53   ` Hollis Blanchard
2018-07-19 21:38 ` Peter Korsgaard [this message]
2018-08-08 14:10   ` Peter Korsgaard
2018-08-08 20:37     ` Arnout Vandecappelle
2018-08-09  0:19       ` Hollis Blanchard
2018-08-09 14:28       ` Peter Korsgaard

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=8736wec3d8.fsf@dell.be.48ers.dk \
    --to=peter@korsgaard.com \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox