Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Peter Korsgaard <peter@korsgaard.com>
To: buildroot@busybox.net
Subject: [Buildroot] [git commit] package/libunwind: disable for x86 with uClibc toolchain
Date: Mon, 24 Apr 2017 21:31:25 +0200	[thread overview]
Message-ID: <8737cxvbzm.fsf@dell.be.48ers.dk> (raw)
In-Reply-To: <20170417130858.BC09A826C1@busybox.osuosl.org> (Thomas Petazzoni's message of "Mon, 17 Apr 2017 15:08:22 +0200")

>>>>> "Thomas" == Thomas Petazzoni <thomas.petazzoni@free-electrons.com> writes:

 > commit: https://git.buildroot.net/buildroot/commit/?id=c5b56b0a20b2be24878d8bae66fbe665e8fea698
 > branch: https://git.buildroot.net/buildroot/commit/?id=refs/heads/master

 > libunwind use sigreturn() while building for x86 [1] but this function
 > is not available with uClibc-ng.

 > This throw a warning during libunwind build:
 > In file included from x86/Los-linux.c:4:0:
 > x86/Gos-linux.c: In function ??_ULx86_local_resume??:
 > x86/Gos-linux.c:298:7: warning: implicit declaration of function ??sigreturn?? [-Wimplicit-function-declaration]
 >        sigreturn (sc);
 >        ^

 > But any program trying to link against libunwind-generic.so fail to build:
 > [...]usr/lib/libunwind-generic.so: undefined reference to `sigreturn'
 > collect2: error: ld returned 1 exit status

 > Disable libunwind for x86 target when uClibc-ng is used.

 > Fixes:
 > http://autobuild.buildroot.net/results/54a/54afac8148cff5f3c17e83f80917fd9006948fe0//build-end.log

 > [1] http://git.savannah.gnu.org/gitweb/?p=libunwind.git;a=blob;f=src/x86/Gos-linux.c;h=17aebc2974af50eb0bf8292689b2ed22a4c97866;hb=HEAD#l299

 > Signed-off-by: Romain Naour <romain.naour@gmail.com>
 > Tested-by: "Yann E. MORIN" <yann.morin.1998@free.fr>
 > Acked-by: "Yann E. MORIN" <yann.morin.1998@free.fr>
 > Signed-off-by: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>

Committed to 2017.02.x, thanks.

-- 
Bye, Peter Korsgaard

      reply	other threads:[~2017-04-24 19:31 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-04-17 13:08 [Buildroot] [git commit] package/libunwind: disable for x86 with uClibc toolchain Thomas Petazzoni
2017-04-24 19:31 ` Peter Korsgaard [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=8737cxvbzm.fsf@dell.be.48ers.dk \
    --to=peter@korsgaard.com \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox