From mboxrd@z Thu Jan 1 00:00:00 1970 From: Vivien Didelot Date: Tue, 13 Sep 2016 18:59:04 -0400 Subject: [Buildroot] [PATCH] infra/pkg-kconfig: Be sure to reconfigure the package on foo-reconfigure In-Reply-To: <1473806117-3858-1-git-send-email-yann.morin.1998@free.fr> References: <1473806117-3858-1-git-send-email-yann.morin.1998@free.fr> Message-ID: <8737l3be4n.fsf@ketchup.mtl.sfl> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: buildroot@busybox.net Hi, "Yann E. MORIN" writes: > Currently, calling foo-reconfigure for a kconfig-based package will not > re-trigger the configuration (kconfig-wise) step for the package. > > This can be problematic when using an override-srcdir suring development > and the content of the veride-srcdir changes (e.g. on a rebase, a merge, > or during a bisect). > > This is because the configuration (kconfig-wise) of the package is not > done in the _CONFIGURE_CMDS block, but as a separate action that is not > part of any step [0]. > > So, be sure to remove the stamp file .stamp_kconfig_fixup_done during > the foo-clean-for-reconfigure rule, so that the configuration is applied > again with the new source tree. > > We use another rule, foo-clean-kconfig-for-reconfigure, because we do > not want to override the default foo-clean-for-reconfigure rule, and we > have no way to add conditional commands to it. > > [0] The reasons it was not done are not entirely clear in my head, but > IIRC that was not working at the time we tried with Thomas DS. > > Reported-by: Vivien Didelot > Signed-off-by: "Yann E. MORIN" > Cc: Vivien Didelot > Cc: Thomas De Schampheleire > Cc: Thomas Petazzoni Without this patch, make linux-rebuild or make linux-reconfigure will prompt new kernel symbols, which is painful when rebasing/bisecting. With this patch, make linux-rebuild will still prompt new symbols, but make linux-reconfigure will not, which is intuitive. Tested-by: Vivien Didelot Thanks, Vivien