[Buildroot] [PATCHv3 02/15] directfb: mark as available only for gcc >= 4.5

[Peter Korsgaard <peter@korsgaard.com>]

>>>>> "Thomas" == Thomas Petazzoni <thomas.petazzoni@free-electrons.com> writes:

 > The new DirectFB version does not build with gcc 4.3 from the Blackfin
 > toolchain. One of the reason is that va_copy has some issues, which
 > were fixed in gcc 4.4.0
 > (https://gcc.gnu.org/bugzilla/show_bug.cgi?id=36799). There are also
 > some other issues, which were fixed by a patch proposed by Peter
 > Seiderer at
 > http://lists.busybox.net/pipermail/buildroot/2015-February/120281.html.

 > However, it probably doesn't make a lot of sense to carry patches that
 > are not upstream for such old compilers. Instead, this commit takes
 > the action of making DirectFB available only on toolchains using gcc
 >> = 4.5, which was tested with the Arago toolchain. gcc 4.4 could
 > potentially work, but wasn't tested (it is no longer supported by the
 > internal toolchain backend, and we don't have any toolchain based on
 > gcc 4.4), so we take the safe decision of requiring at least gcc 4.5.

 > Signed-off-by: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
 > ---
 > This commit could be squashed into the DirectFB bump itself for
 > bisectability, but was kept separate to ease the review.

Committed with the comments added as suggested by Vincente.

 > +++ b/package/gstreamer/gst-plugins-bad/Config.in
 > @@ -263,6 +263,10 @@ config BR2_PACKAGE_GST_PLUGINS_BAD_PLUGIN_DIRECTFB
 >  	select BR2_PACKAGE_DIRECTFB
 >  	depends on BR2_TOOLCHAIN_HAS_THREADS
 >  	depends on BR2_INSTALL_LIBSTDCPP
 > +	depends on BR2_TOOLCHAIN_GCC_AT_LEAST_4_5
 > +
 > +comment "directfb needs a toolchain w/ C++, threads, gcc >= 4.5"
 > +	depends on !BR2_TOOLCHAIN_HAS_THREADS || !BR2_INSTALL_LIBSTDCPP || !BR2_TOOLCHAIN_GCC_AT_LEAST_4_5

Not directly related to this commit, but even though directfb is a
library I think it makes more sense to use 'depends on' (and default y)
for these options for "big libraries", as:

- People are likely to explicitly enable those libraroes if they want
  them

- Gstreamer support size is insignificant compared to the library, and
  people are likely to want E.G. directfb support in gstreamer if they
  enable directfb and gstreamer, so the default y is nice

- We don't need to propagate the (often fairly complicated) library
  dependencies to the users

This applies for E.G. wayland and Qt as well.

But that can (should) be handled outside this series.

-- 
Bye, Peter Korsgaard