From: Peter Korsgaard <jacmet@uclibc.org>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH] bzip2: Rearrange build order
Date: Wed, 05 Jun 2013 16:15:34 +0200 [thread overview]
Message-ID: <8738swej95.fsf@dell.be.48ers.dk> (raw)
In-Reply-To: <20130605160438.2a47341b@skate> (Thomas Petazzoni's message of "Wed, 5 Jun 2013 16:04:38 +0200")
>>>>> "Thomas" == Thomas Petazzoni <thomas.petazzoni@free-electrons.com> writes:
>> This works, but is afaik less efficient for the static lib case.
>>
>> The real fix is imho to build the object files twice, like how libtool
>> does it.
>>
>> If you look at the Debian package, they work around it by adding a
>> seperate .c -> .sho build rule, which adds -fPIC, and then link the .so
>> file with the .sho files instead.
Thomas> Are you sure there are not already many packages that build
Thomas> things only once with -fPIC and use that for both the static
Thomas> and the shared library?
Thomas> What you're proposing here is quite the opposite to what you
Thomas> merged (from me) in a33baa1ef9dadbec8e45d411c30d636fa6b8872a
Thomas> (icu: don't build object files twice).
I've never claimed I was consistent ;) What I'm saying is simply that
the "correct" way to do this, is to build the object files twice similar
to how E.G. libtool does it.
For something as small (and possibly performance sensitive) as bzip2 I
think it is worthwhile doing it.
--
Bye, Peter Korsgaard
next prev parent reply other threads:[~2013-06-05 14:15 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-06-05 12:56 [Buildroot] [PATCH] bzip2: Rearrange build order Markos Chandras
2013-06-05 13:08 ` Thomas Petazzoni
2013-06-05 13:50 ` Peter Korsgaard
2013-06-05 14:02 ` Markos Chandras
2013-06-05 14:04 ` Thomas Petazzoni
2013-06-05 14:08 ` Markos Chandras
2013-06-05 14:15 ` Peter Korsgaard [this message]
2013-06-05 14:25 ` Markos Chandras
2013-06-05 14:48 ` Peter Korsgaard
2013-06-05 15:01 ` Markos Chandras
2013-06-05 15:22 ` Thomas Petazzoni
2013-06-05 21:56 ` Peter Korsgaard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8738swej95.fsf@dell.be.48ers.dk \
--to=jacmet@uclibc.org \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox