From: Peter Korsgaard <jacmet@uclibc.org>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH] pkg-download.mk: Fix shallow clone
Date: Sun, 02 Dec 2012 08:05:34 -0800 [thread overview]
Message-ID: <8738zo7835.fsf@dell.be.48ers.dk> (raw)
In-Reply-To: <1354445767-15308-1-git-send-email-sho@relinux.de> (Stephan Hoffmann's message of "Sun, 2 Dec 2012 11:56:07 +0100")
>>>>> "Stephan" == Stephan Hoffmann <sho@relinux.de> writes:
Stephan> Some git versions (e.g. 1.7.0) do not treat trying to shallow clone
Stephan> a non existing branch or tag as a fatal error but report a warning
Stephan> and clone HEAD instead. Thus the fallback mechanism does not work
Stephan> in this case.
Stephan> This patch introduces a check for the presence of the requested
Stephan> version as a branch or tag before trying the shallow clone. It
Stephan> also removes the need to do two clones when a sha1 is given as
Stephan> a packege version.
Thanks, committed.
I really do think we need to move the git handling into an external
script, because this isn't really readable anymore - But that's for
post-2012.11.
I've changed the cut -b 42- into cut -f2- as that's more robust (and
readable imho).
--
Bye, Peter Korsgaard
next prev parent reply other threads:[~2012-12-02 16:05 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-12-02 10:56 [Buildroot] [PATCH] pkg-download.mk: Fix shallow clone Stephan Hoffmann
2012-12-02 16:05 ` Peter Korsgaard [this message]
2012-12-06 2:14 ` Danomi Manchego
2012-12-06 7:03 ` Arnout Vandecappelle
2012-12-06 10:59 ` Stephan Hoffmann
2012-12-06 11:28 ` Danomi Manchego
2012-12-06 10:34 ` Stephan Hoffmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8738zo7835.fsf@dell.be.48ers.dk \
--to=jacmet@uclibc.org \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox