From mboxrd@z Thu Jan 1 00:00:00 1970 From: Peter Korsgaard Date: Thu, 30 Dec 2010 21:54:51 +0100 Subject: [Buildroot] commiting patches In-Reply-To: <20101230063005.15755osot9w5qwco@www.home.zuerker.org> (Heiko Zuerker's message of "Thu, 30 Dec 2010 06:30:05 -0600") References: <20101230063005.15755osot9w5qwco@www.home.zuerker.org> Message-ID: <8739pfhtgk.fsf@macbook.be.48ers.dk> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: buildroot@busybox.net >>>>> "Heiko" == Heiko Zuerker writes: Heiko> Hey, Heiko> I was wondering for a while, what are the criterias for patches Heiko> to be applied to buildroot. Heiko> Some of them seem to get applied right away, others were sent in a Heiko> month or two ago and don't. I understand that some probably will never Heiko> get applied, but will there be a "sorry dude, but..." email? I'm not following any strict procedure, but I do try to sooner or later get around to review all patches. Understand that I do this in my spare time, so turnaround time can sometimes be slow. I mainly try to handle the patches in fifo mode, but I do also skim new mails. This is both because sometimes updates are sent, and sometimes I see trivial patches that can be handled when I have 5 min spare or important bugfixes. It's a big help when other developers help with the review and send their ack/nacks (thanks for this!), so those patches are often handled earlier than others. But I can still forget about patches, so if you haven't had any feedback for a week or two, please check if it still applies and send a followup mail. It might be politically incorrect, but the patch author also does matter. If the patch is from a regular contributor who normally does good work, then I know I don't need to review in as much details as if it's from a complete stranger - So a good way of getting your own patches applied faster is to help reviewing other patches ;) -- Bye, Peter Korsgaard