Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Peter Korsgaard <jacmet@uclibc.org>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 1/3] Add libxpm as a dependency of ace_of_penguins
Date: Fri, 19 Feb 2010 11:12:28 +0100	[thread overview]
Message-ID: <873a0xlek3.fsf@macbook.be.48ers.dk> (raw)
In-Reply-To: <3df93063da925eb9787be0a98ce88d079173f762.1266536162.git.thomas.petazzoni@free-electrons.com> (Thomas Petazzoni's message of "Fri, 19 Feb 2010 00:36:04 +0100")

>>>>> "Thomas" == Thomas Petazzoni <thomas.petazzoni@free-electrons.com> writes:

 Thomas> ace_of_penguins fails to build when xlib_libXpm is not selected. Add
 Thomas> it has a dependency. However, contrary to normal dependencies to
 Thomas> libraries (where we use 'select') we use 'depends on' here, otherwise
 Thomas> the X.org server will be get selected automatically without the user
 Thomas> noticing.

 Thomas> Signed-off-by: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
 Thomas> ---
 Thomas>  package/games/ace_of_penguins/Config.in          |    1 +
 Thomas>  package/games/ace_of_penguins/ace_of_penguins.mk |    2 +-
 Thomas>  2 files changed, 2 insertions(+), 1 deletions(-)

 Thomas> diff --git a/package/games/ace_of_penguins/Config.in b/package/games/ace_of_penguins/Config.in
 Thomas> index edbaf26..1d5a367 100644
 Thomas> --- a/package/games/ace_of_penguins/Config.in
 Thomas> +++ b/package/games/ace_of_penguins/Config.in
 Thomas> @@ -2,6 +2,7 @@ config BR2_PACKAGE_ACE_OF_PENGUINS
 Thomas>  	bool "ace_of_penguins"
 Thomas>  	select BR2_PACKAGE_LIBPNG
 Thomas>  	depends on BR2_PACKAGE_XORG7
 Thomas> +	depends on BR2_PACKAGE_XLIB_LIBXPM

But we already depend on XORG7, so selecting LIBXPM seems ok to me?
Longer term we should certainly make it possible to build X stuff
without also building a X server.


-- 
Bye, Peter Korsgaard

  reply	other threads:[~2010-02-19 10:12 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-02-18 23:36 [Buildroot] [pull request] Pull request for branch misc-fixes4 Thomas Petazzoni
2010-02-18 23:36 ` [Buildroot] [PATCH 1/3] Add libxpm as a dependency of ace_of_penguins Thomas Petazzoni
2010-02-19 10:12   ` Peter Korsgaard [this message]
2010-02-18 23:36 ` [Buildroot] [PATCH 2/3] Fix build failure of rubix Thomas Petazzoni
2010-02-18 23:36 ` [Buildroot] [PATCH 3/3] xboard: remove package Thomas Petazzoni

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=873a0xlek3.fsf@macbook.be.48ers.dk \
    --to=jacmet@uclibc.org \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox