Re: [Buildroot] [PATCH] package/libecoli: fix uninitialized width build failure with -Ofast

[Peter Korsgaard <peter@korsgaard.com>]

>>>>> "Yegor" == Yegor Yefremov via buildroot <buildroot@buildroot.org> writes:

 > libecoli builds with -Werror. With GCC 15 and BR2_OPTIMIZE_FAST, the
 > build fails with:

 >   ../src/editline.c: In function 'ec_editline_complete':
 >   ../src/editline.c:304:22: error: 'width' may be used uninitialized [-Werror=maybe-uninitialized]
 >   ../src/editline.c: In function 'ec_editline_interact':
 >   ../src/editline.c:657:22: error: 'width' may be used uninitialized [-Werror=maybe-uninitialized]

 > This is a real bug: ec_editline_term_size() only writes its width
 > output when both el_get(EL_GETTC) calls succeed, and these two callers
 > neither check its return value nor initialize width beforehand.

 > Add a patch, submitted upstream, that defaults width to 80 columns, as
 > the other ec_editline_term_size() callers already do.

 > This issue has been present since commit 5638ee04c8dd ("package/libecoli:
 > bump version to 0.11.3"), as upstream commit bc90312a4285 ("editline:
 > split in 2 files"), first released in v0.11.0, dropped the width
 > initialization. It therefore affects 2026.08 and later. The 2026.02.x
 > LTS branch still has libecoli 0.10.1 and is not affected.

 > Fixes:
 > https://autobuild.buildroot.org/results/a0a7e17f1a76588932a8a7f8db35a832d540cc69

 > Fixes: 5638ee04c8dddb9ebfb7b047efb574f657e1b052 ("package/libecoli: bump version to 0.11.3")
 > Assisted-by: Claude:claude-opus-5-5
 > Signed-off-by: Yegor Yefremov <yegorslists@googlemail.com>

Committed, thanks.

-- 
Bye, Peter Korsgaard
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot