* [Buildroot] [PATCH] package/webkitgtk: disable JIT for all MIPS CPUs
@ 2024-08-23 12:32 Adrian Perez de Castro
0 siblings, 0 replies; 4+ messages in thread
From: Adrian Perez de Castro @ 2024-08-23 12:32 UTC (permalink / raw)
To: buildroot; +Cc: Adrian Perez de Castro
Change the mips32r6 into a blanket BR2_mips[el] check to disable the
JSC JIT. Upstream removed JIT support for all MIPS processors in
January 2024 [0], and the change trickled down to stable releases
starting on version 2.44.0 [1].
While at it, change the upstream bug links to point to a more
appropriate bug report.
[0] https://commits.webkit.org/272866@main
[1] https://lists.webkit.org/pipermail/webkit-wpe/2023-September/000612.html
Signed-off-by: Adrian Perez de Castro <aperez@igalia.com>
---
package/webkitgtk/webkitgtk.mk | 16 +++++++---------
1 file changed, 7 insertions(+), 9 deletions(-)
diff --git a/package/webkitgtk/webkitgtk.mk b/package/webkitgtk/webkitgtk.mk
index 468fefab0e..9aaff5da8f 100644
--- a/package/webkitgtk/webkitgtk.mk
+++ b/package/webkitgtk/webkitgtk.mk
@@ -130,18 +130,16 @@ else
WEBKITGTK_CONF_OPTS += -DENABLE_JOURNALD_LOG=OFF
endif
-# JIT is not supported for MIPS r6, but the WebKit build system does not
-# have a check for these processors. The same goes for ARMv5 and ARMv6.
+# JIT is not supported for MIPS, ARMv5, and ARMv6, but the WebKit build
+# system does not have a check for these processors.
+#
# Disable JIT forcibly here and use the CLoop interpreter instead.
+# Also, we have to disable the sampling profiler and WebAssembly, which
+# do NOT work with ENABLE_C_LOOP.
#
-# Also, we have to disable the sampling profiler and webassembly,
-# which does NOT work with ENABLE_C_LOOP.
+# Upstream bug: https://bugs.webkit.org/show_bug.cgi?id=278559
#
-# Upstream bugs: https://bugs.webkit.org/show_bug.cgi?id=191258
-# https://bugs.webkit.org/show_bug.cgi?id=172765
-# https://bugs.webkit.org/show_bug.cgi?id=265218
-#
-ifeq ($(BR2_ARM_CPU_ARMV5)$(BR2_ARM_CPU_ARMV6)$(BR2_MIPS_CPU_MIPS32R6)$(BR2_MIPS_CPU_MIPS64R6),y)
+ifeq ($(BR2_ARM_CPU_ARMV5)$(BR2_ARM_CPU_ARMV6)$(BR2_mips)$(BR2_mipsel),y)
WEBKITGTK_CONF_OPTS += -DENABLE_JIT=OFF -DENABLE_C_LOOP=ON \
-DENABLE_SAMPLING_PROFILER=OFF \
-DENABLE_WEBASSEMBLY=OFF
--
2.46.0
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
^ permalink raw reply related [flat|nested] 4+ messages in thread
* [Buildroot] [PATCH] package/webkitgtk: disable JIT for all MIPS CPUs
@ 2026-02-28 19:44 Adrian Perez de Castro
2026-03-01 14:02 ` Peter Korsgaard
2026-03-06 19:53 ` Thomas Perale via buildroot
0 siblings, 2 replies; 4+ messages in thread
From: Adrian Perez de Castro @ 2026-02-28 19:44 UTC (permalink / raw)
To: buildroot; +Cc: Adrian Perez de Castro
Change the mips32r6 into a blanket BR2_mips[el] check to disable the
JSC JIT. Upstream removed JIT support for all MIPS processors in
January 2024 [0], and the change trickled down to stable releases
starting on version 2.44.0 [1].
While at it, change the upstream bug links to point to a more
appropriate bug report.
[0] https://commits.webkit.org/272866@main
[1] https://lists.webkit.org/archives/list/webkit-wpe@lists.webkit.org/thread/JM7GLPPKGAB6DIQ2YDHPEIWNOYSUHBC7/
Signed-off-by: Adrian Perez de Castro <aperez@igalia.com>
---
package/webkitgtk/webkitgtk.mk | 16 +++++++---------
1 file changed, 7 insertions(+), 9 deletions(-)
diff --git a/package/webkitgtk/webkitgtk.mk b/package/webkitgtk/webkitgtk.mk
index d9aa48f024..161807bc5a 100644
--- a/package/webkitgtk/webkitgtk.mk
+++ b/package/webkitgtk/webkitgtk.mk
@@ -173,18 +173,16 @@ else
WEBKITGTK_CONF_OPTS += -DENABLE_JOURNALD_LOG=OFF
endif
-# JIT is not supported for MIPS r6, but the WebKit build system does not
-# have a check for these processors. The same goes for ARMv5 and ARMv6.
+# JIT is not supported for MIPS, ARMv5, and ARMv6, but the WebKit build
+# system does not have a check for some of these target processors.
+#
# Disable JIT forcibly here and use the CLoop interpreter instead.
+# Also, we have to disable the sampling profiler and WebAssembly, which
+# do NOT work with ENABLE_C_LOOP.
#
-# Also, we have to disable the sampling profiler and webassembly,
-# which does NOT work with ENABLE_C_LOOP.
+# Upstream bug: https://bugs.webkit.org/show_bug.cgi?id=278559
#
-# Upstream bugs: https://bugs.webkit.org/show_bug.cgi?id=191258
-# https://bugs.webkit.org/show_bug.cgi?id=172765
-# https://bugs.webkit.org/show_bug.cgi?id=265218
-#
-ifeq ($(BR2_ARM_CPU_ARMV5)$(BR2_ARM_CPU_ARMV6)$(BR2_MIPS_CPU_MIPS32R6)$(BR2_MIPS_CPU_MIPS64R6),y)
+ifeq ($(BR2_ARM_CPU_ARMV5)$(BR2_ARM_CPU_ARMV6)$(BR2_mips)$(BR2_mipsel),y)
WEBKITGTK_CONF_OPTS += -DENABLE_JIT=OFF -DENABLE_C_LOOP=ON \
-DENABLE_SAMPLING_PROFILER=OFF \
-DENABLE_WEBASSEMBLY=OFF
--
2.53.0
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [Buildroot] [PATCH] package/webkitgtk: disable JIT for all MIPS CPUs
2026-02-28 19:44 [Buildroot] [PATCH] package/webkitgtk: disable JIT for all MIPS CPUs Adrian Perez de Castro
@ 2026-03-01 14:02 ` Peter Korsgaard
2026-03-06 19:53 ` Thomas Perale via buildroot
1 sibling, 0 replies; 4+ messages in thread
From: Peter Korsgaard @ 2026-03-01 14:02 UTC (permalink / raw)
To: Adrian Perez de Castro; +Cc: buildroot
>>>>> "Adrian" == Adrian Perez de Castro <aperez@igalia.com> writes:
> Change the mips32r6 into a blanket BR2_mips[el] check to disable the
> JSC JIT. Upstream removed JIT support for all MIPS processors in
> January 2024 [0], and the change trickled down to stable releases
> starting on version 2.44.0 [1].
> While at it, change the upstream bug links to point to a more
> appropriate bug report.
> [0] https://commits.webkit.org/272866@main
> [1]
> https://lists.webkit.org/archives/list/webkit-wpe@lists.webkit.org/thread/JM7GLPPKGAB6DIQ2YDHPEIWNOYSUHBC7/
> Signed-off-by: Adrian Perez de Castro <aperez@igalia.com>
Committed, thanks.
--
Bye, Peter Korsgaard
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [Buildroot] [PATCH] package/webkitgtk: disable JIT for all MIPS CPUs
2026-02-28 19:44 [Buildroot] [PATCH] package/webkitgtk: disable JIT for all MIPS CPUs Adrian Perez de Castro
2026-03-01 14:02 ` Peter Korsgaard
@ 2026-03-06 19:53 ` Thomas Perale via buildroot
1 sibling, 0 replies; 4+ messages in thread
From: Thomas Perale via buildroot @ 2026-03-06 19:53 UTC (permalink / raw)
To: Adrian Perez de Castro; +Cc: Thomas Perale, buildroot
In reply of:
> Change the mips32r6 into a blanket BR2_mips[el] check to disable the
> JSC JIT. Upstream removed JIT support for all MIPS processors in
> January 2024 [0], and the change trickled down to stable releases
> starting on version 2.44.0 [1].
>
> While at it, change the upstream bug links to point to a more
> appropriate bug report.
>
> [0] https://commits.webkit.org/272866@main
> [1] https://lists.webkit.org/archives/list/webkit-wpe@lists.webkit.org/thread/JM7GLPPKGAB6DIQ2YDHPEIWNOYSUHBC7/
>
> Signed-off-by: Adrian Perez de Castro <aperez@igalia.com>
Applied to 2025.02.x & 2025.11.x. Thanks
> ---
> package/webkitgtk/webkitgtk.mk | 16 +++++++---------
> 1 file changed, 7 insertions(+), 9 deletions(-)
>
> diff --git a/package/webkitgtk/webkitgtk.mk b/package/webkitgtk/webkitgtk.mk
> index d9aa48f024..161807bc5a 100644
> --- a/package/webkitgtk/webkitgtk.mk
> +++ b/package/webkitgtk/webkitgtk.mk
> @@ -173,18 +173,16 @@ else
> WEBKITGTK_CONF_OPTS += -DENABLE_JOURNALD_LOG=OFF
> endif
>
> -# JIT is not supported for MIPS r6, but the WebKit build system does not
> -# have a check for these processors. The same goes for ARMv5 and ARMv6.
> +# JIT is not supported for MIPS, ARMv5, and ARMv6, but the WebKit build
> +# system does not have a check for some of these target processors.
> +#
> # Disable JIT forcibly here and use the CLoop interpreter instead.
> +# Also, we have to disable the sampling profiler and WebAssembly, which
> +# do NOT work with ENABLE_C_LOOP.
> #
> -# Also, we have to disable the sampling profiler and webassembly,
> -# which does NOT work with ENABLE_C_LOOP.
> +# Upstream bug: https://bugs.webkit.org/show_bug.cgi?id=278559
> #
> -# Upstream bugs: https://bugs.webkit.org/show_bug.cgi?id=191258
> -# https://bugs.webkit.org/show_bug.cgi?id=172765
> -# https://bugs.webkit.org/show_bug.cgi?id=265218
> -#
> -ifeq ($(BR2_ARM_CPU_ARMV5)$(BR2_ARM_CPU_ARMV6)$(BR2_MIPS_CPU_MIPS32R6)$(BR2_MIPS_CPU_MIPS64R6),y)
> +ifeq ($(BR2_ARM_CPU_ARMV5)$(BR2_ARM_CPU_ARMV6)$(BR2_mips)$(BR2_mipsel),y)
> WEBKITGTK_CONF_OPTS += -DENABLE_JIT=OFF -DENABLE_C_LOOP=ON \
> -DENABLE_SAMPLING_PROFILER=OFF \
> -DENABLE_WEBASSEMBLY=OFF
> --
> 2.53.0
>
> _______________________________________________
> buildroot mailing list
> buildroot@buildroot.org
> https://lists.buildroot.org/mailman/listinfo/buildroot
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2026-03-06 19:53 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-02-28 19:44 [Buildroot] [PATCH] package/webkitgtk: disable JIT for all MIPS CPUs Adrian Perez de Castro
2026-03-01 14:02 ` Peter Korsgaard
2026-03-06 19:53 ` Thomas Perale via buildroot
-- strict thread matches above, loose matches on Subject: below --
2024-08-23 12:32 Adrian Perez de Castro
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox