Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Baruch Siach via buildroot <buildroot@buildroot.org>
To: Dario Binacchi <dario.binacchi@amarulasolutions.com>
Cc: buildroot@buildroot.org,  linux-amarula@amarulasolutions.com
Subject: Re: [Buildroot] [PATCH 1/2] package/pocketpy: new package
Date: Thu, 29 May 2025 15:18:29 +0300	[thread overview]
Message-ID: <874ix3ehka.fsf@tarshish> (raw)
In-Reply-To: <20250529103129.2349689-1-dario.binacchi@amarulasolutions.com> (Dario Binacchi's message of "Thu, 29 May 2025 12:31:28 +0200")

Hi Dario,

On Thu, May 29 2025, Dario Binacchi wrote:
> diff --git a/package/pocketpy/pocketpy.mk b/package/pocketpy/pocketpy.mk
> new file mode 100644
> index 000000000000..d81086859890
> --- /dev/null
> +++ b/package/pocketpy/pocketpy.mk
> @@ -0,0 +1,21 @@
> +################################################################################
> +#
> +# pocketpy
> +#
> +################################################################################
> +
> +POCKETPY_VERSION = 2.0.8
> +POCKETPY_SITE = $(call github,pocketpy,pocketpy,v$(POCKETPY_VERSION))
> +POCKETPY_LICENSE = MIT
> +POCKETPY_LICENSE_FILES = LICENSE
> +
> +POCKETPY_CONF_OPTS = -DPK_BUILD_SHARED_LIB=ON
> +
> +define POCKETPY_INSTALL_TARGET_CMDS
> +	$(INSTALL) -D -m 0755 $(@D)/libpocketpy.so* $(TARGET_DIR)/usr/lib
> +	$(INSTALL) -D -m 0755 $(@D)/libpocketpy.so* $(STAGING_DIR)/usr/lib
> +	$(INSTALL) -m 755 -d $(STAGING_DIR)/usr/include/pocketpy
> +	cp -r $(@D)/include/* $(STAGING_DIR)/usr/include/pocketpy

Why install to STAGING_DIR in target install command? This should be in
INSTALL_STAGING_CMDS.

baruch

> +endef
> +
> +$(eval $(cmake-package))

-- 
                                                     ~. .~   Tk Open Systems
=}------------------------------------------------ooO--U--Ooo------------{=
   - baruch@tkos.co.il - tel: +972.52.368.4656, http://www.tkos.co.il -
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

      parent reply	other threads:[~2025-05-29 12:18 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-05-29 10:31 [Buildroot] [PATCH 1/2] package/pocketpy: new package Dario Binacchi
2025-05-29 10:31 ` [Buildroot] [PATCH 2/2] package/canopenterm: " Dario Binacchi
2025-05-29 12:18 ` Baruch Siach via buildroot [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=874ix3ehka.fsf@tarshish \
    --to=buildroot@buildroot.org \
    --cc=baruch@tkos.co.il \
    --cc=dario.binacchi@amarulasolutions.com \
    --cc=linux-amarula@amarulasolutions.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox