From: Peter Korsgaard <peter@korsgaard.com>
To: Cody Green <cody@londelec.com>
Cc: buildroot@buildroot.org
Subject: Re: [Buildroot] [PATCH] package/sysvinit: add version number to SYSVINIT_MAKE_OPTS
Date: Mon, 11 Nov 2024 11:35:38 +0100 [thread overview]
Message-ID: <874j4ecb2d.fsf@dell.be.48ers.dk> (raw)
In-Reply-To: <CAFQdmxL-C6cxpEaOJmfWzxB80W2deVsiu5mJ9J-rgHZO9zVnTQ@mail.gmail.com> (Cody Green's message of "Sat, 5 Oct 2024 15:15:39 +0100")
>>>>> "Cody" == Cody Green <cody@londelec.com> writes:
> Version environment variable VERSION=$(VERSION) is set in the top level
> Makefile of the sysvinit:
> $(MAKE) VERSION=$(VERSION) -C src $@
> Build command SYSVINIT_BUILD_CMDS doesn't use the top level Makefile, but
> src/Makefile instead without setting the VERSION variable, which leads to
> undefined VERSION macro in src/init.c.
> Add VERSION=$(SYSVINIT_VERSION) to SYSVINIT_MAKE_OPTS to make the VERSION
> environment variable available in the src/Makefile.
> Signed-off-by: Cody Green <cody@londelec.com>
Committed to 2024.02.x and 2024.08.x, thanks.
--
Bye, Peter Korsgaard
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
prev parent reply other threads:[~2024-11-11 10:35 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CAFQdmxKcoojruP+5Cebkm_oqCzBx657NddiTJ+nJi_u0AChJzA@mail.gmail.com>
[not found] ` <CAFQdmxJ-p8TV4wK=TJxUb0D8hGscODzXApgZviemrQiUEf+y1w@mail.gmail.com>
2024-10-05 14:15 ` [Buildroot] [PATCH] package/sysvinit: add version number to SYSVINIT_MAKE_OPTS Cody Green
2024-10-26 11:51 ` Thomas Petazzoni via buildroot
2024-11-11 10:35 ` Peter Korsgaard [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=874j4ecb2d.fsf@dell.be.48ers.dk \
--to=peter@korsgaard.com \
--cc=buildroot@buildroot.org \
--cc=cody@londelec.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox