From: Peter Korsgaard <peter@korsgaard.com>
To: Fabrice Fontaine <fontaine.fabrice@gmail.com>
Cc: buildroot@buildroot.org
Subject: Re: [Buildroot] [PATCH v2,1/1] linux: disable -Werror
Date: Thu, 21 Mar 2024 21:12:59 +0100 [thread overview]
Message-ID: <874jcz8htg.fsf@48ers.dk> (raw)
In-Reply-To: <20240306192604.381763-1-fontaine.fabrice@gmail.com> (Fabrice Fontaine's message of "Wed, 6 Mar 2024 20:26:04 +0100")
>>>>> "Fabrice" == Fabrice Fontaine <fontaine.fabrice@gmail.com> writes:
> Disable -Werror to fix the following build failure with esp-hosted
> raised at least since commit a382a7d55432918d2a1e47ae4cbe7ed50fa17a08:
> In function ‘destroy_cmd_wq’,
> inlined from ‘esp_commands_teardown’ at /home/autobuild/autobuild/instance-4/output-1/build/esp-hosted-ce3c50a33fa4bc562a1b6cbcee292c1ae0b0a404/esp_hosted_ng/host/esp_cmd.c:1467:2:
> ./include/linux/workqueue.h:639:9: error: call to ‘__warn_flushing_systemwide_wq’ declared with attribute warning: Please avoid flushing system-wide workqueues. [-Werror=attribute-warning]
> 639 | __warn_flushing_systemwide_wq(); \
> | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> /home/autobuild/autobuild/instance-4/output-1/build/esp-hosted-ce3c50a33fa4bc562a1b6cbcee292c1ae0b0a404/esp_hosted_ng/host/esp_cmd.c:408:17:
> note: in expansion of macro ‘flush_scheduled_work’
> 408 | flush_scheduled_work();
> | ^~~~~~~~~~~~~~~~~~~~
> Fixes:
> - http://autobuild.buildroot.org/results/6ac7a4601938d3296ed1657c06f8cdf433757d73
> - http://autobuild.buildroot.org/results/7997cc8a67645a6e1cf4e24d172c6feae459dcfb
> Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
> ---
> Changes v1 -> v2 (after review of Peter Korsgaard):
> - Move disabling of -Werror from esp-hosted to linux.mk
Committed to 2024.02.x, thanks.
--
Bye, Peter Korsgaard
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
prev parent reply other threads:[~2024-03-21 20:13 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-06 19:26 [Buildroot] [PATCH v2,1/1] linux: disable -Werror Fabrice Fontaine
2024-03-07 13:05 ` Peter Korsgaard
2024-03-21 20:12 ` Peter Korsgaard [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=874jcz8htg.fsf@48ers.dk \
--to=peter@korsgaard.com \
--cc=buildroot@buildroot.org \
--cc=fontaine.fabrice@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox