From: Peter Korsgaard <peter@korsgaard.com>
To: Thomas Petazzoni via buildroot <buildroot@buildroot.org>
Cc: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
Subject: Re: [Buildroot] [git commit] package/libglib2: fix libiconv handling
Date: Mon, 11 Sep 2023 12:30:24 +0200 [thread overview]
Message-ID: <874jk1c88v.fsf@48ers.dk> (raw)
In-Reply-To: <20230807215218.8ECE084777@busybox.osuosl.org> (Thomas Petazzoni via buildroot's message of "Mon, 7 Aug 2023 23:49:16 +0200")
>>>>> "Thomas" == Thomas Petazzoni via buildroot <buildroot@buildroot.org> writes:
> commit: https://git.buildroot.net/buildroot/commit/?id=ff050de534eed1dab152890d748952fc659882a0
> branch: https://git.buildroot.net/buildroot/commit/?id=refs/heads/master
> In upstream commit e71ecc8771a4f13bc6046438ab0845944831b9a6 ("build:
> Remove deprecated -Diconv option"), merged since glib 2.75.1, the
> meson -Diconv option was removed.
> In Buildroot, this means that the build of libglib2 has been broken
> since commit 3f9622fe3d85b4d9f734b879abc1d485afea19b2, which bumped
> libglib2 from 2.72.3 to 2.76.1 for configurations that have libiconv
> enabled, causing this build failure:
> ../output-1/build/libglib2-2.76.1/meson.build:1:0: ERROR: Unknown options: "iconv"
> iconv is now automatically detected by Meson machinery, and so the
> option was considered as no longer being needed. This commit fixes
> that by dropping the useless -Diconv=external.
> Another related change done is remove the double addition of libiconv
> into the <pkg>_DEPENDENCIES variable: libiconv can only be enabled
> when BR2_ENABLE_LOCALE is disabled, and libglib2/Config.in selects
> BR2_PACKAGE_LIBICONV when !BR2_ENABLE_LOCALE. So testing
> BR2_ENABLE_LOCALE!=y and BR2_PACKAGE_LIBICONV=y is exactly the same
> thing, causing libiconv to be added twice to the dependencies.
> Fixes:
> http://autobuild.buildroot.net/results/d2da03f7558f3b6ee59c813bb64115702e52704c/
> Signed-off-by: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
Committed to 2023.05.x, thanks.
--
Bye, Peter Korsgaard
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
prev parent reply other threads:[~2023-09-11 10:30 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-07 21:49 [Buildroot] [git commit] package/libglib2: fix libiconv handling Thomas Petazzoni via buildroot
2023-09-11 10:30 ` Peter Korsgaard [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=874jk1c88v.fsf@48ers.dk \
--to=peter@korsgaard.com \
--cc=buildroot@buildroot.org \
--cc=thomas.petazzoni@bootlin.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox