Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Peter Korsgaard <peter@korsgaard.com>
To: <Eugen.Hristev@microchip.com>
Cc: Jason@zx2c4.com, buildroot@buildroot.org
Subject: Re: [Buildroot] [PATCH] package/urandom-scripts: do not seed if initial seed doesn't exist
Date: Mon, 18 Apr 2022 22:50:09 +0200	[thread overview]
Message-ID: <874k2q6rr2.fsf@dell.be.48ers.dk> (raw)
In-Reply-To: <0f4e63a3-6b82-aaf0-47af-54102e91ccfb@microchip.com> (Eugen Hristev's message of "Mon, 18 Apr 2022 20:19:13 +0000")

>>>>>   <Eugen.Hristev@microchip.com> writes:

 > On 4/16/22 4:47 PM, Peter Korsgaard wrote:
 >>>>>>> "Jason" == Jason A Donenfeld <Jason@zx2c4.com> writes:
 >> 
 >> > By returning a failure in the event that the initial seed doesn't exist,
 >> > we'd then skip creating a new seed, which means we'd never in fact have
 >> > an initial seed, and this script is therefore useless. Fix this by
 >> > checking for the existence of the seed file first, and just returning 0
 >> > if it's not there.
 >> 
 >> > Reported-by: Nicolas Cavallari <Nicolas.Cavallari@green-communications.fr>
 >> > Reported-by: Eugen Hristev <Eugen.Hristev@microchip.com>
 >> > Signed-off-by: Jason A. Donenfeld <Jason@zx2c4.com>
 >> 
 >> Committed, thanks.
 >> 
 >> --
 >> Bye, Peter Korsgaard
 >> 


 > Hi Jason,

 > I cherry-picked this patch to my 2022.02.1 tree, and rebuilt my images.
 > I still see this message at boot time :

 > "Initializing random number generator: FAIL"

 > Any ideas about what I could try ?

Not really. If you see the message, then that must mean that
/var/lib/random-seed exists in your rootfs. Can you provide some more
details about your setup, E.G. what kind of rootfs file system, is it
mounted R/W, what platform, kernel version?

What error message do you get from dd if you run the dd to /dev/urandom
statement manually?

-- 
Bye, Peter Korsgaard
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

  parent reply	other threads:[~2022-04-18 20:50 UTC|newest]

Thread overview: 29+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-03-23  3:52 [Buildroot] [PATCH] package/urandom-scripts: hash old seed with new seed when saving Jason A. Donenfeld
2022-03-23  5:10 ` Jason A. Donenfeld
2022-03-23  8:43 ` Nicolas Cavallari
2022-03-23  9:13 ` Yann E. MORIN
2022-03-23 13:39   ` Nicolas Cavallari
2022-03-23 20:06   ` Jason A. Donenfeld
2022-03-23 20:07     ` [Buildroot] [PATCH v2] " Jason A. Donenfeld
2022-03-24  8:24       ` Yann E. MORIN
2022-03-24  9:15         ` David Laight
2022-03-24 10:09           ` Yann E. MORIN
2022-03-24 10:25             ` David Laight
2022-03-24 10:39               ` Yann E. MORIN
2022-03-24 13:06                 ` David Laight
2022-03-24 13:54           ` Jason A. Donenfeld
2022-03-24 14:31             ` David Laight
2022-03-24 14:39               ` Jason A. Donenfeld
2022-03-28 13:17         ` Peter Korsgaard
2022-04-15 10:54           ` Eugen.Hristev--- via buildroot
2022-04-15 12:25             ` Nicolas Cavallari
2022-04-16 11:12               ` Peter Korsgaard
2022-04-16 11:31                 ` [Buildroot] [PATCH] package/urandom-scripts: do not seed if initial seed doesn't exist Jason A. Donenfeld
2022-04-16 13:47                   ` Peter Korsgaard
2022-04-18 20:19                     ` Eugen.Hristev--- via buildroot
2022-04-18 20:36                       ` Jason A. Donenfeld
2022-04-19 10:23                         ` Eugen.Hristev--- via buildroot
2022-04-18 20:50                       ` Peter Korsgaard [this message]
2022-05-22 10:11                   ` Peter Korsgaard
2022-04-16  8:29             ` [Buildroot] [PATCH v2] package/urandom-scripts: hash old seed with new seed when saving Peter Korsgaard
2022-03-24  2:41     ` [Buildroot] [PATCH] " Jason A. Donenfeld

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=874k2q6rr2.fsf@dell.be.48ers.dk \
    --to=peter@korsgaard.com \
    --cc=Eugen.Hristev@microchip.com \
    --cc=Jason@zx2c4.com \
    --cc=buildroot@buildroot.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox