Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Peter Korsgaard <peter@korsgaard.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 1/1] duktape: new package
Date: Mon, 13 Nov 2017 21:55:31 +0100	[thread overview]
Message-ID: <874lpx5264.fsf@dell.be.48ers.dk> (raw)
In-Reply-To: <CAPi7W80e2AUko7WXdKbbZ9pBQE+SDUHnKTstA7386msnVOEuxg@mail.gmail.com> (Fabrice Fontaine's message of "Fri, 3 Nov 2017 23:20:17 +0100")

>>>>> "Fabrice" == Fabrice Fontaine <fontaine.fabrice@gmail.com> writes:

Hi,

 > The issue with the original Makefile is that it tries to copy the two
 > header files in $(TARGET_DIR)/usr/include which does not exist so I had
 > several choices:
 > - create this directory in duktape.mk
 > - add "-a" option to the cp in the original Makefile

But cp -a doesn't create missing directories?

> - remove the cp

 > I chose the third option but I can go with the first or second one. Which
 > one do you prefer?

I would prefer to see a mkdir -p to ensure the directory exists and/or
using install -D to copy the files, as such patches should be acceptable
upstream.

-- 
Bye, Peter Korsgaard

  reply	other threads:[~2017-11-13 20:55 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-11-03 19:53 [Buildroot] [PATCH 1/1] duktape: new package Fabrice Fontaine
2017-11-03 21:35 ` Thomas Petazzoni
2017-11-03 22:20   ` Fabrice Fontaine
2017-11-13 20:55     ` Peter Korsgaard [this message]
2017-12-03 22:42 ` Thomas Petazzoni

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=874lpx5264.fsf@dell.be.48ers.dk \
    --to=peter@korsgaard.com \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox