From mboxrd@z Thu Jan 1 00:00:00 1970 From: Peter Korsgaard Date: Thu, 27 Apr 2017 23:36:01 +0200 Subject: [Buildroot] [PATCH v10 1/2] genimage.sh: fix calling from BR2_ROOTFS_POST_IMAGE_SCRIPT In-Reply-To: <20170424052445.7637-1-abhimanyu.v@gmail.com> (Abhimanyu Vishwakarma's message of "Mon, 24 Apr 2017 10:54:45 +0530") References: <20170424052445.7637-1-abhimanyu.v@gmail.com> Message-ID: <874lx9jzy6.fsf@dell.be.48ers.dk> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: buildroot@busybox.net >>>>> "Abhimanyu" == Abhimanyu Vishwakarma writes: > From: Abhimanyu Vishwakarma > When called from BR2_ROOTFS_POST_IMAGE_SCRIPT, this script > ends up with following error: > Error: Missing argument > This is because, an extra positional argument is also passed > along with BR2_ROOTFS_POST_SCRIPT_ARGS. genimage.sh didn't > have support to parse positional and optional arguments > together. > Signed-off-by: Abhimanyu Vishwakarma > Reviewed-by: Arnout Vandecappelle (Essensium/Mind) > Tested-by: Rahul Bedarkar > --- > Changes v7->v8 > - New file > Changes v8->v9 > - Fix indentation > - Use bash basename as script name instead hardcoding (by arnout) > Changes v9->v10 (Suggested by Arnout) > - Remove tab indentation (use existing 2 space indent) > - Fix commit message grammer > - add reviewed-by tag > - keep tested-by tag as no code change just indentation > support/scripts/genimage.sh | 19 ++++++++++++++----- > 1 file changed, 14 insertions(+), 5 deletions(-) Committed, thanks. -- Bye, Peter Korsgaard