Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Peter Korsgaard <peter@korsgaard.com>
To: buildroot@busybox.net
Subject: [Buildroot] ADP5588 - Platform data
Date: Tue, 13 Dec 2016 19:57:32 +0100	[thread overview]
Message-ID: <874m273bdv.fsf@dell.be.48ers.dk> (raw)
In-Reply-To: <CAFMv-czcQedXA8nPsJgrEaZYJYg8UqW8ePO4NWB64=1BGwC=7A@mail.gmail.com> (Leonardo Giordano's message of "Tue, 13 Dec 2016 15:08:38 -0300")

>>>>> "Leonardo" == Leonardo Giordano <lgiordano@controlnet.com.ar> writes:

 > Hi,
 > My board has and ADP5588 IC (it is an I2C matrix keyboard scanner).

This kind of kernel questions are really more suited for one of the
kernel lists, E.G. the input or i2c lists.

 > I enabled the ADP5588 at kernel configuration.
 > Then I added the following section to i2c at dts file:

 > adp5588: keyboard at 1b {
 > compatible = "adp5588-keys";
 > reg = <0x1b>;
 > interrupt-parent = <&pioC>;
 > interrupts = <1 0x0>;
 > pinctrl-names = "default";
 > pinctrl-0 = <&pinctrl_adp5588_irq>;
 > wakeup-source;
 > };

Where did you get this from? As far as I can see there isn't any
devicetree support in that driver of any bindings documented.

 > However, at adp5588_probe() function (drivers/input/keyboard/adp5588.c), it
 > fails when trying to get platform data:

 > const struct adp5588_kpad_platform_data *pdata =
 >  dev_get_platdata(&client->dev);

 > pdata points to null.

The driver has to be extended with devicetree bindings to get the
information that used to be encoded in the platform data from the DT.

-- 
Bye, Peter Korsgaard

  reply	other threads:[~2016-12-13 18:57 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-12-13 18:08 [Buildroot] ADP5588 - Platform data Leonardo Giordano
2016-12-13 18:57 ` Peter Korsgaard [this message]
2016-12-13 19:11   ` Leonardo Giordano

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=874m273bdv.fsf@dell.be.48ers.dk \
    --to=peter@korsgaard.com \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox