From: Peter Korsgaard <jacmet@uclibc.org>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 2/3] qt: Install QtDeclarative imports
Date: Sun, 26 Feb 2012 22:28:59 +0100 [thread overview]
Message-ID: <874nudi8ro.fsf@macbook.be.48ers.dk> (raw)
In-Reply-To: <1330258388-28391-2-git-send-email-ismael.luceno@gmail.com> (Ismael Luceno's message of "Sun, 26 Feb 2012 10:13:07 -0200")
>>>>> "Ismael" == Ismael Luceno <ismael.luceno@gmail.com> writes:
Please sign off on your patches! (git format-patch -s).
Ismael> ---
Ismael> package/qt/qt.mk | 7 +++++--
Ismael> 1 files changed, 5 insertions(+), 2 deletions(-)
Ismael> diff --git a/package/qt/qt.mk b/package/qt/qt.mk
Ismael> index 68f9348..4871538 100644
Ismael> --- a/package/qt/qt.mk
Ismael> +++ b/package/qt/qt.mk
Ismael> @@ -594,9 +594,12 @@ endif
Ismael> # Plugin installation
Ismael> define QT_INSTALL_TARGET_PLUGINS
Ismael> + mkdir -p $(TARGET_DIR)/usr/lib/qt
Ismael> if [ -d $(STAGING_DIR)/usr/lib/qt/plugins/ ] ; then \
Ismael> - mkdir -p $(TARGET_DIR)/usr/lib/qt/plugins ; \
Ismael> - cp -dpfr $(STAGING_DIR)/usr/lib/qt/plugins/* $(TARGET_DIR)/usr/lib/qt/plugins ; \
Ismael> + cp -dpfr $(STAGING_DIR)/usr/lib/qt/plugins $(TARGET_DIR)/usr/lib/qt ; \
Ismael> + fi
Ismael> + if [ -d $(@D)/imports ] ; then \
Ismael> + cp -dpfr $(@D)/imports $(TARGET_DIR)/usr/lib/qt ; \
It would make more sense to add the mkdir -p inside this
conditional. Is there any reason why you are copying from the source
directory and not staging like above?
Care to fix that and resend with your signed-off-by?
--
Bye, Peter Korsgaard
next prev parent reply other threads:[~2012-02-26 21:28 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-02-26 12:13 [Buildroot] [PATCH 1/3] qt: remove bogus lines Ismael Luceno
2012-02-26 12:13 ` [Buildroot] [PATCH 2/3] qt: Install QtDeclarative imports Ismael Luceno
2012-02-26 21:28 ` Peter Korsgaard [this message]
2012-02-28 20:56 ` Arnout Vandecappelle
2012-02-26 12:13 ` [Buildroot] [PATCH 3/3] qt: Add option to build and install tools on the target Ismael Luceno
2012-02-28 21:09 ` Arnout Vandecappelle
2012-02-26 21:25 ` [Buildroot] [PATCH 1/3] qt: remove bogus lines Peter Korsgaard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=874nudi8ro.fsf@macbook.be.48ers.dk \
--to=jacmet@uclibc.org \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox