From: Peter Korsgaard <jacmet@sunsite.dk>
To: buildroot@busybox.net
Subject: [Buildroot] [git commit] busybox: only install S01logging if syslogd applet is enabled
Date: Wed, 23 Nov 2011 22:41:45 +0100 [thread overview]
Message-ID: <874nxuo6sm.fsf@macbook.be.48ers.dk> (raw)
In-Reply-To: <8739deq3pp.fsf@macbook.be.48ers.dk> (Peter Korsgaard's message of "Wed, 23 Nov 2011 16:05:22 +0100")
>>>>> "Peter" == Peter Korsgaard <jacmet@sunsite.dk> writes:
Hi,
Maxime> While it shouldn't happen in the common use-case, because of
Maxime> the dependency we set on busybox in all the logger packages, if
Maxime> the user put his init script for another logger in the
Maxime> skeleton, it will always remove it, and install the default
Maxime> one.
Maxime> Maybe the common name was not such a good idea, and that we
Maxime> should have a distinct name for each init scripts. Or we revert
Maxime> this commit. I don't know.
Peter> For 2011.11 I would suggest we just remove the 2nd part (E.G. removal of
Peter> init script if syslog daemon isn't enabled) - The first part is needed
Peter> to support custom S01logging scripts with busybox (E.G. I have projects
Peter> where we log to shared memory instead of files, so you need -S option to
Peter> syslogd).
Peter> Once 2011.11 is out, then we should probably rename the files to work
Peter> around this.
Peter> I'll fix - Thanks for bringing it out.
Ehh, I had a closer look, and I don't see any issues:
- If sysklogd applet is enabled in busybox we install S01logging
- If "big" sysklogd is enabled we don't install anything (bug)
- If rsyslogd is enabled we install S01rsyslog
So we don't have multiple system loggers using the same file name - Did
you just mean that we should rename S01logging to something like
S01bbsysklog instead?
--
Bye, Peter Korsgaard
next prev parent reply other threads:[~2011-11-23 21:41 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-07-04 19:03 [Buildroot] [git commit] busybox: only install S01logging if syslogd applet is enabled Peter Korsgaard
2011-11-23 11:40 ` Maxime Ripard
2011-11-23 15:05 ` Peter Korsgaard
2011-11-23 21:41 ` Peter Korsgaard [this message]
2011-11-23 21:56 ` Maxime Ripard
2011-11-23 22:16 ` Peter Korsgaard
2011-11-24 8:03 ` Maxime Ripard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=874nxuo6sm.fsf@macbook.be.48ers.dk \
--to=jacmet@sunsite.dk \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox