From: Peter Korsgaard <peter@korsgaard.com>
To: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
Cc: Romain Naour <romain.naour@gmail.com>,
Giulio Benetti <giulio.benetti@benettiengineering.com>,
Buildroot List <buildroot@buildroot.org>
Subject: Re: [Buildroot] [PATCH] package/gcc/gcc-final: only install libgcc_s for shared library builds
Date: Sat, 30 Sep 2023 17:38:37 +0200 [thread overview]
Message-ID: <875y3racxu.fsf@48ers.dk> (raw)
In-Reply-To: <20230930151502.650185-1-thomas.petazzoni@bootlin.com> (Thomas Petazzoni's message of "Sat, 30 Sep 2023 17:15:02 +0200")
>>>>> "Thomas" == Thomas Petazzoni <thomas.petazzoni@bootlin.com> writes:
> In commit
> 55e83008fc82cf621d94d60ab4401a4848880bc2 ("package/gcc/gcc-final:
> rework installation of libgcc_s/libatomic"), we reworked the libgcc_s
> installation. In the previous code, libgcc_s was installed to
> STAGING_DIR/TARGET_DIR unconditionally, but a "-cp" command was used,
> which means that any failure was ignored. As we are now more picky, it
> has become clear that this in fact wasn't entirely correct: libgcc_s
> only exists for shared builds. For static builds, only libgcc.a is
> available, but it doesn't need to be installed to STAGING_DIR (for
> some reason, and as it was never installed by Buildroot, it has always
> worked without libgcc.a in STAGING_DIR).
> So long story short: we change the code to only install libgcc_s when
> BR2_STATIC_LIBS is disabled. This fixes the following build failure on
> BR2_STATIC_LIBS=y builds:
> cp -dpf
> /home/thomas/buildroot/buildroot/output/host/arm-buildroot-linux-uclibcgnueabi/lib*/libgcc_s*
> /home/thomas/buildroot/buildroot/output/host/arm-buildroot-linux-uclibcgnueabi/sysroot/lib/
> cp: cannot stat
> '/home/thomas/buildroot/buildroot/output/host/arm-buildroot-linux-uclibcgnueabi/lib*/libgcc_s*':
> No such file or directory
> Reported-by: Peter Korsgaard <peter@korsgaard.com>
> Signed-off-by: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
Committed to 2023.08.x, thanks.
--
Bye, Peter Korsgaard
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
next prev parent reply other threads:[~2023-09-30 15:38 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-30 15:15 [Buildroot] [PATCH] package/gcc/gcc-final: only install libgcc_s for shared library builds Thomas Petazzoni via buildroot
2023-09-30 15:38 ` Peter Korsgaard [this message]
2023-09-30 15:41 ` Peter Korsgaard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=875y3racxu.fsf@48ers.dk \
--to=peter@korsgaard.com \
--cc=buildroot@buildroot.org \
--cc=giulio.benetti@benettiengineering.com \
--cc=romain.naour@gmail.com \
--cc=thomas.petazzoni@bootlin.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox