From: Peter Korsgaard <peter@korsgaard.com>
To: Baruch Siach <baruch@tkos.co.il>
Cc: "Yann E. MORIN" <yann.morin.1998@free.fr>,
Ricardo Martincoski <ricardo.martincoski@datacom.com.br>,
buildroot@buildroot.org
Subject: Re: [Buildroot] [PATCH] utils/docker-run: make it work in workdirs/woktrees
Date: Tue, 13 Jun 2023 18:46:25 +0200 [thread overview]
Message-ID: <875y7rwbry.fsf@48ers.dk> (raw)
In-Reply-To: <87sfavqyc8.fsf@tarshish> (Baruch Siach's message of "Tue, 13 Jun 2023 16:33:57 +0300")
>>>>> "Baruch" == Baruch Siach <baruch@tkos.co.il> writes:
> Hi Peter,
> On Tue, Jun 13 2023, Peter Korsgaard wrote:
>>>>>>> "Yann" == Yann E MORIN <yann.morin.1998@free.fr> writes:
>>
>> > It is quite customary to use a single repository with multiple workdirs,
>> > one for each active branch, with either the aging 'git new-workdir' or
>> > the more recent 'git worktree'.
>>
>> > However, in a workdir/worktree, most entries in .git/ are only symlinks
>> > to the actual files in the main repository.
>>
>> > Currently, utils/docker-run only bind-mounts the current working copy.
>> > If that is a workdir/worktree, then it is going to be missing the actual
>> > git data, resulting in errors like:
>>
>> > $ ./utils/docker-run make check-package
>> > fatal: not a git repository (or any parent up to mount point [....]/buildroot)
>> > Stopping at filesystem boundary (GIT_DISCOVERY_ACROSS_FILESYSTEM not set).
>> > No files to check style
>> > make: *** [Makefile:1257: check-package] Error 1
>>
>> > So, we also bind-mount the actual git directory. If that is a subdir
>> > of the current working copy, then it is already mounted and thus the
>> > bind-mount is superfluous but harmless; for simplicity, we mount it
>> > unconditionally.
>>
>> > Signed-off-by: Yann E. MORIN <yann.morin.1998@free.fr>
>> > Cc: Ricardo Martincoski <ricardo.martincoski@datacom.com.br>
>>
>> Committed to 2023.02.x, thanks.
> Not in 2023.02.x branch as of commit bcddc639d.
Ups, fixed now - Thanks.
--
Bye, Peter Korsgaard
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
prev parent reply other threads:[~2023-06-13 16:46 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-06 21:46 [Buildroot] [PATCH] utils/docker-run: make it work in workdirs/woktrees Yann E. MORIN
2023-05-13 10:10 ` Yann E. MORIN
2023-06-13 12:37 ` Peter Korsgaard
2023-06-13 13:33 ` Baruch Siach via buildroot
2023-06-13 16:46 ` Peter Korsgaard [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=875y7rwbry.fsf@48ers.dk \
--to=peter@korsgaard.com \
--cc=baruch@tkos.co.il \
--cc=buildroot@buildroot.org \
--cc=ricardo.martincoski@datacom.com.br \
--cc=yann.morin.1998@free.fr \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox