From: Peter Korsgaard <peter@korsgaard.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH v2 1/2] package/sdl2: remove sdl2-config.cmake
Date: Thu, 16 Jul 2020 18:20:22 +0200 [thread overview]
Message-ID: <875zantos9.fsf@dell.be.48ers.dk> (raw)
In-Reply-To: <20200505184303.609201-1-romain.naour@gmail.com> (Romain Naour's message of "Tue, 5 May 2020 20:43:02 +0200")
>>>>> "Romain" == Romain Naour <romain.naour@gmail.com> writes:
> We are using autotools build system for sdl2, so the sdl2-config.cmake
> include path are not resolved like for sdl2-config script [1].
> Remove sdl2-config.cmake file and avoid unsafe include path if this
> file is used by a cmake based package.
> This trigger an issue with ogre 1.12.6 package that replaced
> FindSDL2.cmake by sdl2-config.cmake [2].
> Thanks to Pavel Rojtberg for the help [3].
> [1] https://bugzilla.libsdl.org/show_bug.cgi?id=4597
> [2] https://github.com/OGRECave/ogre/commit/6de6f9b4081a07c911932441700c54b72ec1ee1f
> [3] https://github.com/OGRECave/ogre/issues/1568
> Signed-off-by: Romain Naour <romain.naour@gmail.com>
Committed to 2020.02.x and 2020.05.x, thanks.
--
Bye, Peter Korsgaard
prev parent reply other threads:[~2020-07-16 16:20 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-05 18:43 [Buildroot] [PATCH v2 1/2] package/sdl2: remove sdl2-config.cmake Romain Naour
2020-05-05 18:43 ` [Buildroot] [PATCH v2 2/2] package/orgre: bump to version 1.12.6 Romain Naour
2020-06-24 21:51 ` [Buildroot] [PATCH v2 1/2] package/sdl2: remove sdl2-config.cmake Thomas Petazzoni
2020-07-16 16:20 ` Peter Korsgaard [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=875zantos9.fsf@dell.be.48ers.dk \
--to=peter@korsgaard.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox