From: Peter Korsgaard <peter@korsgaard.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH v1 3/4] package/pinentry: add missing qt5 dependencies
Date: Fri, 27 Mar 2020 07:42:19 +0100 [thread overview]
Message-ID: <875zeqguyc.fsf@dell.be.48ers.dk> (raw)
In-Reply-To: <20200315233839.5a91a231@windsurf.home> (Thomas Petazzoni's message of "Sun, 15 Mar 2020 23:38:39 +0100")
>>>>> "Thomas" == Thomas Petazzoni <thomas.petazzoni@bootlin.com> writes:
> On Tue, 10 Mar 2020 09:19:01 +0100
> Peter Seiderer <ps.report@gmx.net> wrote:
>> -comment "pinentry-qt5 needs a toolchain w/ wchar, NPTL, C++, dynamic library"
>> +comment "pinentry-qt5 needs a toolchain w/ wchar, NPTL, gcc >= 4.8, C++, dynamic library"
>> depends on !BR2_INSTALL_LIBSTDCPP || !BR2_USE_WCHAR || \
>> - !BR2_TOOLCHAIN_HAS_THREADS_NPTL || BR2_STATIC_LIBS
>> + !BR2_TOOLCHAIN_HAS_THREADS_NPTL || !BR2_TOOLCHAIN_GCC_AT_LEAST_4_8 || \
>> + !BR2_arc || BR2_STATIC_LIBS
> This is not the correct way to take into account architecture
> dependencies. It should be:
> comment "pinentry-qt5 needs a toolchain w/ wchar, NPTL, gcc >= 4.8, C++, dynamic library"
> depends on !BR2_arc
> depends on !BR2_INSTALL_LIBSTDCPP || !BR2_USE_WCHAR || \
> !BR2_TOOLCHAIN_HAS_THREADS_NPTL || !BR2_TOOLCHAIN_GCC_AT_LEAST_4_8 || \
> BR2_STATIC_LIBS
> I fixed that and applied. Thanks!
Committed to 2020.02.x, thanks.
--
Bye, Peter Korsgaard
next prev parent reply other threads:[~2020-03-27 6:42 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-10 8:18 [Buildroot] [PATCH v1 1/4] package/qt5: enable for nios2 Peter Seiderer
2020-03-10 8:19 ` [Buildroot] [PATCH v1 2/4] package/qt5: enable for xtensa Peter Seiderer
2020-03-15 22:37 ` Thomas Petazzoni
2020-03-27 6:40 ` Peter Korsgaard
2020-03-10 8:19 ` [Buildroot] [PATCH v1 3/4] package/pinentry: add missing qt5 dependencies Peter Seiderer
2020-03-15 22:38 ` Thomas Petazzoni
2020-03-27 6:42 ` Peter Korsgaard [this message]
2020-03-10 8:19 ` [Buildroot] [PATCH v1 4/4] package/wireshark: " Peter Seiderer
2020-03-15 22:39 ` Thomas Petazzoni
2020-03-27 6:42 ` Peter Korsgaard
2020-03-15 22:37 ` [Buildroot] [PATCH v1 1/4] package/qt5: enable for nios2 Thomas Petazzoni
2020-03-21 22:33 ` Peter Korsgaard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=875zeqguyc.fsf@dell.be.48ers.dk \
--to=peter@korsgaard.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox