Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Peter Korsgaard <peter@korsgaard.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH] azure-iot-sdk-c: Bump to version 2018-12-13
Date: Fri, 21 Dec 2018 23:02:11 +0100	[thread overview]
Message-ID: <875zvmtu70.fsf@dell.be.48ers.dk> (raw)
In-Reply-To: <20181221173729.41870-1-Nikita.Sobolev@synopsys.com> (Nikita Sobolev's message of "Fri, 21 Dec 2018 20:37:29 +0300")

>>>>> "Nikita" == Nikita Sobolev <Nikita.Sobolev@synopsys.com> writes:

 > From: NikitaSobolev <Nikita.Sobolev@synopsys.com>
 > Bump azure-iot-sdk-c to 2018-12-13 release.
 > Add patch, that removes Windows specified variables from
 > azure-iot-sdk-c-2018-12-13 release. That variables cause
 > build errors.

 > Signed-off-by: Nikita Sobolev <Nikita.Sobolev@synopsys.com>
 > ---
 >  ...-azure-iot-sdk-c-Delete-windows-variables.patch | 34 ++++++++++++++++++++++
 >  package/azure-iot-sdk-c/azure-iot-sdk-c.mk         |  2 +-
 >  2 files changed, 35 insertions(+), 1 deletion(-)
 >  create mode 100644 package/azure-iot-sdk-c/0001-azure-iot-sdk-c-Delete-windows-variables.patch

 > diff --git
 > a/package/azure-iot-sdk-c/0001-azure-iot-sdk-c-Delete-windows-variables.patch
 > b/package/azure-iot-sdk-c/0001-azure-iot-sdk-c-Delete-windows-variables.patch
 > new file mode 100644
 > index 0000000000..e8ff53cb5a
 > --- /dev/null
 > +++ b/package/azure-iot-sdk-c/0001-azure-iot-sdk-c-Delete-windows-variables.patch
 > @@ -0,0 +1,34 @@
 > +From 6c01ef50e0c2d562388aacbb60a1506e70db2218 Mon Sep 17 00:00:00 2001
 > +From: Nikita Sobolev <Nikita.Sobolev@synopsys.com>
 > +Date: Thu, 20 Dec 2018 19:31:20 +0300
 > +Subject: [PATCH] azure-iot-sdk-c: Delete windows variables
 > +
 > +Delete windows specified variables, that have been added
 > +to azure-iot-sdk-c-2018-12-13 release. These variables
 > +are not defined for Linux and cause build errors.
 > +
 > +Signed-off-by: Nikita Sobolev <Nikita.Sobolev@synopsys.com>
 > +---
 > + c-utility/CMakeLists.txt | 6 ------
 > + 1 file changed, 6 deletions(-)
 > +
 > +diff --git a/c-utility/CMakeLists.txt b/c-utility/CMakeLists.txt
 > +index 190ea87dca..464d6d1069 100644
 > +--- a/c-utility/CMakeLists.txt
 > ++++ b/c-utility/CMakeLists.txt
 > +@@ -264,12 +264,6 @@ if(${use_applessl})
 > +     include_directories(./pal/ios-osx/)
 > + endif()
 > + 
 > +-if (WIN32 AND (${CMAKE_SYSTEM_VERSION} VERSION_EQUAL "10.0.17763.0"
 > OR ${CMAKE_SYSTEM_VERSION} VERSION_GREATER "10.0.17763.0"))
 > +-    # Windows added support for UNIX domain sockets to the OS and SDK
 > +-    # in the Oct 2018 update (10.0.17763.0, aka RS5)
 > +-    add_definitions(-DAF_UNIX_ON_WINDOWS)
 > +-endif()

Can you be more specific what the issue is exactly? Given the WIN32 in
this conditional this should never be true in the context of Buildroot,
so the define shouldn't get added?

-- 
Bye, Peter Korsgaard

  reply	other threads:[~2018-12-21 22:02 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-12-21 17:37 [Buildroot] [PATCH] azure-iot-sdk-c: Bump to version 2018-12-13 Nikita Sobolev
2018-12-21 22:02 ` Peter Korsgaard [this message]
2018-12-24 12:46   ` Nikita Sobolev
2018-12-29 13:05     ` André Hentschel
2018-12-30 21:41 ` Thomas Petazzoni
2019-01-10 22:50   ` Arnout Vandecappelle

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=875zvmtu70.fsf@dell.be.48ers.dk \
    --to=peter@korsgaard.com \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox