From mboxrd@z Thu Jan 1 00:00:00 1970 From: Peter Korsgaard Date: Mon, 26 Feb 2018 09:11:06 +0100 Subject: [Buildroot] [git commit branch/next] linux: allow both in-tree and custom dts files In-Reply-To: <20180225190328.GD2276@scaer> (Yann E. MORIN's message of "Sun, 25 Feb 2018 20:03:28 +0100") References: <20180225171345.A60E48809E@busybox.osuosl.org> <20180225190328.GD2276@scaer> Message-ID: <87606ktbl1.fsf@dell.be.48ers.dk> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: buildroot@busybox.net >>>>> "Yann" == Yann E MORIN writes: > Simon, All, > On 2018-02-25 17:19 +0100, Arnout Vandecappelle spake thusly: >> commit: https://git.buildroot.net/buildroot/commit/?id=382fe9f9261812682eab2d35e47aa94dc554380e >> branch: https://git.buildroot.net/buildroot/commit/?id=refs/heads/next >> >> For some boards, for example the Raspberry Pi, it's necessary to build >> in-tree dts files as well as custom/out of tree dts-files (dt-blob.bin). >> The existing logic made these two options exclusive, this commit changes >> that to allow both in-tree as well as custom sources for dts files. > This breaks all our cufrrent defconfig files that build a DTB, like > for example configs/stm32f429_disco_defconfig, because the default > that was implied by a choice is no longer true, so we need to add > BR2_LINUX_KERNEL_USE_INTREE_DTS=y to those defconfig files. That still doesn't fix it for any external defconfig. Adding a 'default y' to BR2_LINUX_KERNEL_USE_INTREE_DTS will likewise break it for users of BR2_LINUX_KERNEL_USE_CUSTOM_DTS. Perhaps we can change the logic to look for nonempty BR2_LINUX_KERNEL_INTREE_DTS_NAME / BR2_LINUX_KERNEL_CUSTOM_DTS_PATH variables? -- Bye, Peter Korsgaard