Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Peter Korsgaard <peter@korsgaard.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 2/2] python-psutil: fix build against musl C library
Date: Tue, 20 Sep 2016 12:30:03 +0200	[thread overview]
Message-ID: <8760pq50es.fsf@dell.be.48ers.dk> (raw)
In-Reply-To: <20160920121433.3912ca4a@free-electrons.com> (Thomas Petazzoni's message of "Tue, 20 Sep 2016 12:14:33 +0200")

>>>>> "Thomas" == Thomas Petazzoni <thomas.petazzoni@free-electrons.com> writes:

 > Hello,
 > On Tue, 20 Sep 2016 09:41:27 +0200, Peter Korsgaard wrote:

 >> We NEED both sys/sysinfo.h and the kernel headers (E.G. for ethtool), so
 >> hack around it by ensuring the content of linux/sysinfo.h doesn't get
 >> expanded when building against musl.
 >> 
 >> We cannot do it unconditionally as glibc/uClibc rely on the linux/sysinfo.h
 >> definition. Musl provides no detection define, so instead detect that we
 >> are NOT on glibc/uClibc.

 > This is not really the solution recommended by the musl developers.
 > Instead, the musl developers would suggest to *not* include
 > <linux/sysinfo.h> at all, and instead duplicate the relevant
 > definitions in the userspace program.

Yes, I know it is a hack (as mentioned in the description). The problem
is that the code DOESN'T include linux/sysinfo.h, but it gets indirectly
included from linux/ethtool.h -> linux/kernel.h -> linux/sysinfo.h.

Do you have any suggestion how to fix this in a cleaner way?

-- 
Venlig hilsen,
Peter Korsgaard 

  reply	other threads:[~2016-09-20 10:30 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-09-20  7:41 [Buildroot] [PATCH 1/2] python-psutil: bump to version 4.3.1 Peter Korsgaard
2016-09-20  7:41 ` [Buildroot] [PATCH 2/2] python-psutil: fix build against musl C library Peter Korsgaard
2016-09-20 10:14   ` Thomas Petazzoni
2016-09-20 10:30     ` Peter Korsgaard [this message]
2016-09-20 11:30       ` Thomas Petazzoni
2016-09-20 11:51         ` Peter Korsgaard
2016-09-20 12:38           ` Thomas Petazzoni
2016-09-20 13:04             ` Peter Korsgaard
2016-09-20 12:38 ` [Buildroot] [PATCH 1/2] python-psutil: bump to version 4.3.1 Peter Korsgaard

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=8760pq50es.fsf@dell.be.48ers.dk \
    --to=peter@korsgaard.com \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox