Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Peter Korsgaard <peter@korsgaard.com>
To: buildroot@busybox.net
Subject: [Buildroot] Loading modules with device tree after rootfs is mounted
Date: Sat, 27 Feb 2016 22:47:44 +0100	[thread overview]
Message-ID: <8760x9su4f.fsf@dell.be.48ers.dk> (raw)
In-Reply-To: <56D20B21.70306@mind.be> (Arnout Vandecappelle's message of "Sat,  27 Feb 2016 21:46:25 +0100")

>>>>> "Arnout" == Arnout Vandecappelle <arnout@mind.be> writes:

Hi,

 >> This was cut'n'paste from:
 >> 
 >> http://lists.busybox.net/pipermail/busybox/2014-September/081780.html
 >> 
 >> Replacing the 'sort -u' with cat would also work. I'm not sure exactly
 >> what the pros/cons of using sort -u is.

 >  It removes duplicates from the list.

Yes, that I get. My question is more about if duplicates can ever occur
/ how likely it is that duplicates are present / what is the problem
about duplicates?

I would think that duplicates are sufficiently rare that the
(potentially) extra modprobe calls vs extra overhead of sort vs cat is
probably down in the noise, but we can certainly keep the sort (it does
mean that we depend on another busybox applet though).

 >> As that message states, we also need to make sure that we have a
 >> modprobe understanding the aliases (so not the MODPROBE_SMALL busybox
 >> variant).

 >  I think in our system scripts we are allowed to rely on the things that
 > are enabled in our default busybox config. So that should be OK.

Yes, or we can force the options on, like we do for other things in
busybox.

-- 
Venlig hilsen,
Peter Korsgaard 

      reply	other threads:[~2016-02-27 21:47 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-01-30 17:56 [Buildroot] Loading modules with device tree after rootfs is mounted Tim Michals
2016-01-31 22:52 ` Arnout Vandecappelle
2016-02-27 10:19   ` Peter Korsgaard
2016-02-27 12:09     ` Arnout Vandecappelle
2016-02-27 17:57       ` Peter Korsgaard
2016-02-27 20:46         ` Arnout Vandecappelle
2016-02-27 21:47           ` Peter Korsgaard [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=8760x9su4f.fsf@dell.be.48ers.dk \
    --to=peter@korsgaard.com \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox