From: Peter Korsgaard <peter@korsgaard.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 1/2] dos2unix: add target support
Date: Wed, 02 Sep 2015 08:45:24 +0200 [thread overview]
Message-ID: <87613tpbej.fsf@dell.be.48ers.dk> (raw)
In-Reply-To: <20150902054912.GU17874@tarshish> (Baruch Siach's message of "Wed, 2 Sep 2015 08:49:12 +0300")
>>>>> "Baruch" == Baruch Siach <baruch@tkos.co.il> writes:
Hi,
>> This looks odd - If wchar is only for gettext then we should allow
>> non-locale builds without wchar. A quick test shows that dos2unix uses
>> wchar several places, but this can be disabled if UCS= is passed on the
>> make line (wchar_t is still referred in 3 error prints though).
> It seems like most packages conditionally selecting BR2_PACKAGE_GETTEXT do not
> depend on BR2_USE_WCHAR. But then, how do you prevent gettext build when the
> toolchain has no wchar support? The autobuilder
> (http://autobuild.buildroot.net/?reason=gettext-0.19.5.1) shows no gettext
> build failure.
I believe it is because locale support (in uClibc) implies wchar
support, so BR2_NEEDS_GETTEXT_IF_LOCALE will only be true if locale
support (and hence wchar) is enabled.
>> > DOS2UNIX_VERSION = 7.0
>> > DOS2UNIX_SITE = http://waterlan.home.xs4all.nl/dos2unix
>> > -DOS2UNIX_DEPENDENCIES = host-gettext
>> > DOS2UNIX_LICENSE = BSD-2c
>> > DOS2UNIX_LICENSE_FILES = COPYING.txt
>> > +HOST_DOS2UNIX_DEPENDENCIES = host-gettext
>>
>> If gettext is optional for target builds, why do we then force it for
>> host builds?
> Do we care about host packages binaries size?
No, not very much - But we do care about build time. If there's no need
to build host-gettext then we shouldn't do so.
> In any case, this is a matter for another patch.
Agreed.
--
Venlig hilsen,
Peter Korsgaard
prev parent reply other threads:[~2015-09-02 6:45 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-09-01 6:43 [Buildroot] [PATCH 1/2] dos2unix: add target support Baruch Siach
2015-09-01 6:43 ` [Buildroot] [PATCH 2/2] dos2unix: bump to version 7.3 Baruch Siach
2015-09-01 14:10 ` James Knight
2015-09-01 10:57 ` [Buildroot] [PATCH 1/2] dos2unix: add target support Vicente Olivert Riera
2015-09-01 11:30 ` Baruch Siach
2015-09-01 21:37 ` Peter Korsgaard
2015-09-02 5:49 ` Baruch Siach
2015-09-02 6:45 ` Peter Korsgaard [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87613tpbej.fsf@dell.be.48ers.dk \
--to=peter@korsgaard.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox