From mboxrd@z Thu Jan 1 00:00:00 1970 From: Peter Korsgaard Date: Fri, 07 Jun 2013 10:50:23 +0200 Subject: [Buildroot] [PATCH 1/1] manual: correct error in github tarball information In-Reply-To: (Samuel Martin's message of "Fri, 7 Jun 2013 10:25:29 +0200") References: <20130606234413.AA3569A982@busybox.osuosl.org> <1370563406-3124-1-git-send-email-spenser@gillilanding.com> Message-ID: <8761xqe240.fsf@dell.be.48ers.dk> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: buildroot@busybox.net >>>>> "Samuel" == Samuel Martin writes: >> ------------------------ >> FOO_VERSION = 1234567 >> -FOO_SITE = http://github.com///tarball/ >> +FOO_SITE = http://github.com///tarball/$(FOO_VERSION) >> ------------------------ Samuel> I'd have slightly reword the whole section, since there is no Samuel> difference between FOO_VERSION being a tag or a commit id, Samuel> something like this: Samuel> --- Samuel> ------------------------ Samuel> FOO_VERSION = v1.0 # tag or commit ID Samuel> FOO_SITE = http://github.com///tarball/$(FOO_VERSION) Samuel> ------------------------ Samuel> .Notes Samuel> - The FOO_VERSION can either be a tag or a commit ID. Samuel> - The tarball name generated by github matches the default one from Samuel> Buildroot (e.g.: +foo-1234567.tar.gz+), Samuel> so it is not necessary to specify it in the +.mk+ file. Samuel> - When using a commit ID as version, usually the first 7 characters of Samuel> the SHA1 are enough. Agreed. I've fixed this in git now, thanks. -- Bye, Peter Korsgaard