Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Peter Korsgaard <jacmet@uclibc.org>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH] iftop: new package
Date: Wed, 16 Jan 2013 15:11:45 +0100	[thread overview]
Message-ID: <87622xmd3y.fsf@dell.be.48ers.dk> (raw)
In-Reply-To: <20130116145510.66bdf069@skate> (Thomas Petazzoni's message of "Wed, 16 Jan 2013 14:55:10 +0100")

>>>>> "Thomas" == Thomas Petazzoni <thomas.petazzoni@free-electrons.com> writes:

 Thomas> Dear Bogdan Radulescu,
 Thomas> On Wed, 16 Jan 2013 15:49:38 +0000, Bogdan Radulescu wrote:

 >> +	select BR2_TOOLCHAIN_BUILDROOT_INET_IPV6

 Thomas> No, selecting toolchain options is not correct, and in this particular
 Thomas> case, it would only work for the internal toolchain backend (breaking
 Thomas> the external backend and Crosstool-NG backend).

 Thomas> See package/squid/Config.in for an example.

 Thomas> Basically, you must do something like:

 Thomas> config BR2_PACKAGE_FOO
 Thomas> 	depends on BR2_INET_IPV6

 Thomas> comment "foo requires IPv6 support in toolchain"
 Thomas> 	depends on !BR2_INET_IPV6

Indeed. Also don't forget to sign off on your patch (git commit -s).

-- 
Bye, Peter Korsgaard

  reply	other threads:[~2013-01-16 14:11 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-01-16 15:49 [Buildroot] [PATCH] iftop: new package Bogdan Radulescu
2013-01-16 15:49 ` Bogdan Radulescu
2013-01-16 13:55   ` Thomas Petazzoni
2013-01-16 14:11     ` Peter Korsgaard [this message]
2013-01-20 20:50     ` Peter Korsgaard
2013-01-21 19:24       ` Bogdan Radulescu
2013-01-21 17:48         ` Thomas Petazzoni
2013-01-21 20:40           ` Bogdan Radulescu
2013-01-21 21:59             ` Peter Korsgaard

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87622xmd3y.fsf@dell.be.48ers.dk \
    --to=jacmet@uclibc.org \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox